-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to backfill generic inverter data #253
base: develop
Are you sure you want to change the base?
Conversation
Thanks a lot for your work, I really appreciated it! Yes, to make the import work, InfluxDB must be reachable, so Port 8086 needs to be open. And you are right, the CSV Importer is not ready for the new sensor configuration (v0.15), it pushes all data to the measurement configured as Before merging, I have two things I would like to ask you:
|
In this case yes, the data comes direct from Solar Assistant, which is a great tool btw. It has some good reporting and graphing features (using Grafana), but the biggest feature is that you can actually control your inverter via their WebUI and set some automations for it. It needs to be directly connected to the inverter via a USB or RS2542 cable, though I named it Mqtt because the live data that I am using is coming from MQTT (via Solar Assistant, as it pushes the data to the MQTT broker), so I wanted to be consistent with the named source. Also because the measurements being used came straight from Solectrus when I chose to configure it using an MQTT source. I'll fix the test issue. |
e609fa3
to
1045de7
Compare
Hm, I'm still not happy with the naming - or I totally misunderstood your use case. This repository ( |
I understand your point (naming is hard 😅) The reason I named it If I'm being 100% honest, I did not generate the CSV file using Solar Assistant. While the data does come from it (it reads values from my inverter via a serial connection, and stores them in a InfluxDB instance), I exported this data from a Grafana dashboard (it was the easiest way to get the CSV file) I would love for the name to remain as generic as possible, so maybe |
Ok, I understand your point. But I still hesitate to merge this PR, because it requires the user to have exactly the same CSV format as the one you provided (with columns Also, it does not support additional values which can be handled by SOLECTRUS, like heatpump or wallbox, for example. So, it's not as generic as it could be. In a perfect world, the user should be able to define the columns he wants to import. But of course, implementing this would be a lot of work. Currently, I'm very busy on other parts of SOLECTRUS, so I don't have the time to work on this yet. What do you think about that? I know the feeling when you've been working on a PR for a while and it doesn't get merged... |
This PR adds support to import historical data collected from generic inverters, in particular for data collected via Solar Assistant.
The Solectrus configurator sets the InfluxDB in such a way that it makes it incompatible with the other importers. I initially tried simply changing the headers so that I could use the Sungrow importer but quickly realized that the data was being imported into the wrong measurements.
Here is what the configurator sets up as default:
So using this adapter, plus also setting the
INFLUX_MEASUREMENT_PV
variable topv
allows the exported data from Solar Assistant to be imported into Solectrus.