Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NH-66480: update workflow as amzlinux only work with checkout/action@v3 (or less) #51

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

xuan-cao-swi
Copy link
Contributor

No description provided.

@xuan-cao-swi xuan-cao-swi marked this pull request as ready for review January 24, 2024 15:55
@xuan-cao-swi xuan-cao-swi requested a review from a team as a code owner January 24, 2024 15:55
cheempz
cheempz previously approved these changes Jan 24, 2024
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 curiosity question about the removal of mkdir

@@ -40,7 +40,6 @@ jobs:
- name: Build gem and publish to github package
id: gemstep
run: |
mkdir ~/.gem
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So ~/.gem dir is guaranteed to exist?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, when I first ran it, it indicates the folder already exist, which is different from apm-ruby. I guess the different ruby version make it different. However, I change the workflow to create one if not exist and not create one if exist.

Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xuan-cao-swi!

@xuan-cao-swi xuan-cao-swi merged commit 24cbb19 into main Jan 24, 2024
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants