NH-66480: remove packagecloud and downgrade graphql version #48
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
|
Won't fix https://github.com/solarwinds/solarwinds-apm-ruby/security/code-scanning/3 since can't find better way to sanitize graphql. P.S. current otel graphql instrumentation doesn't have sanitization. |
There was a problem hiding this comment.
Thanks @xuan-cao-swi! Question about the graphql handling and as discussed will wait for your fix on the failing tests.
test/unit/oboe_init_options_test.rb
Outdated
| ENV['SW_APM_COLLECTOR'] = 'collector.abc.bbc.appoptics.com' | ||
|
|
||
| SolarWindsAPM::OboeInitOptions.instance.re_init | ||
| options = SolarWindsAPM::OboeInitOptions.instance.array_for_oboe | ||
|
|
||
| _(options.size).must_equal 21 | ||
| _(options[20]).must_equal 1 | ||
| _(options[20]).must_equal 2 |
There was a problem hiding this comment.
There is no test to confirm an appoptics collector endpoint results in metrics mode of 1 now. This test needs to be fixed to actually "checks for metric mode appoptics".
There was a problem hiding this comment.
Looks good @xuan-cao-swi, just need that metrics mode for AO test fixed.
No description provided.