Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NH-46957: add notice #38

Merged
merged 12 commits into from
Oct 4, 2023
Merged

NH-46957: add notice #38

merged 12 commits into from
Oct 4, 2023

Conversation

xuan-cao-swi
Copy link
Contributor

@xuan-cao-swi xuan-cao-swi commented Jul 21, 2023 •
edited by cheempz
Loading

For https://swicloud.atlassian.net/browse/NH-46957

Note the repository name for new solarwinds-apm v6+ is not yet finalized.

@xuan-cao-swi xuan-cao-swi requested a review from a team July 21, 2023 14:30
swi-jared
swi-jared previously approved these changes Jul 21, 2023
View reviewed changes
cheempz
cheempz reviewed Jul 21, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
cheempz
cheempz reviewed Jul 21, 2023
View reviewed changes
README.md Show resolved Hide resolved
cheempz
cheempz reviewed Jul 21, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
cheempz
cheempz reviewed Jul 21, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
cheempz
cheempz reviewed Jul 21, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@cheempz
Copy link
Contributor

cheempz commented Jul 21, 2023

LOL I've epic failed at making the suggestions for multiple paragraphs. @xuan-cao-swi I hope you don't mind but i'll just commit things to make it easier to read.

swi-jared
swi-jared previously approved these changes Jul 21, 2023
View reviewed changes
@cheempz
Copy link
Contributor

cheempz commented Jul 21, 2023

@xuan-cao-swi did you want to fix the failing tests as part of a different PR?

@xuan-cao-swi xuan-cao-swi requested a review from swi-jared July 24, 2023 15:23
@xuan-cao-swi
Copy link
Contributor Author

@xuan-cao-swi did you want to fix the failing tests as part of a different PR?
Hi Lin, I set the mariadb to last version.

cheempz
cheempz previously approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the tests

swi-jared
swi-jared previously approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@swi-jared swi-jared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if you were blocked on my review, so here you go

@cheempz cheempz dismissed stale reviews from swi-jared and themself via 6476c08 August 30, 2023 23:18
@cheempz cheempz changed the title NH-41925: repo rename and add notice NH-41925: add notice Aug 30, 2023
@cheempz cheempz changed the title NH-41925: add notice NH-46957: add notice Aug 30, 2023
@cheempz
Copy link
Contributor

cheempz commented Aug 30, 2023

@xuan-cao-swi I reverted the changes about repository rename (see rationale in Jira ticket) so this PR would simply be adding the notice... and unfortunately looking at why tests failed 😢

@xuan-cao-swi
Copy link
Contributor Author

@xuan-cao-swi I reverted the changes about repository rename (see rationale in Jira ticket) so this PR would simply be adding the notice... and unfortunately looking at why tests failed 😢

Yeah, the new psych is causing problem. We need to update the dockerfile that install libyaml...

@xuan-cao-swi xuan-cao-swi requested a review from cheempz October 3, 2023 13:44
cheempz
cheempz approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks @xuan-cao-swi!

@cheempz cheempz merged commit 328c86b into main Oct 4, 2023
@cheempz cheempz deleted the NH-41925 branch October 4, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheempz cheempz cheempz approved these changes

@swi-jared swi-jared swi-jared left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xuan-cao-swi @cheempz @swi-jared