NH-69805: lambda layer init commit #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
xuan-cao-swi
changed the title
xuan-cao-swi
force-pushed
the
lambda-layer
branch
from
11b8bed to
75e4894
Compare
cheempz
requested changes
Mar 14, 2024
There was a problem hiding this comment.
Thanks @xuan-cao-swi, really appreciate the example workflow run the layers! Please see my comments. I will also create a follow-on task to investigate the instrumentations bundled into the layer, from a quick look it seems all of the instrumentors are included which may not be necessary.
|
Almost there @xuan-cao-swi! One last tweak per unresolved comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to lack of stable otel-ruby metrics sdk and finished otlp processor, the Gemfile is just for testing as now
Test
sample workflow run: https://github.com/solarwinds/apm-ruby/actions/runs/8197609977
layer location: x86_64, arm64