Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NH-94970: dbo integration for psql #170

Merged
merged 13 commits into from
Jan 8, 2025
Merged

NH-94970: dbo integration for psql #170

merged 13 commits into from
Jan 8, 2025
+252 −641

Conversation

xuan-cao-swi
Copy link
Contributor

@xuan-cao-swi xuan-cao-swi commented Dec 3, 2024 •
edited
Loading

Description

  • Remove the marginalia support
  • For dbo integration, directly customize the query function
  • DRY on annotate_sql part

Test (if applicable)

@xuan-cao-swi xuan-cao-swi marked this pull request as ready for review December 12, 2024 19:58
@xuan-cao-swi xuan-cao-swi requested a review from a team as a code owner December 12, 2024 19:58
cleverchuk
cleverchuk previously approved these changes Dec 16, 2024
View reviewed changes
Copy link

@cleverchuk cleverchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lib/solarwinds_apm/patch/tag_sql/sw_dbo_utils.rb Show resolved Hide resolved
lib/solarwinds_apm/patch/tag_sql/sw_dbo_utils.rb Show resolved Hide resolved
cheempz
cheempz reviewed Dec 23, 2024
View reviewed changes
lib/solarwinds_apm/patch/tag_sql/sw_pg_patch.rb Show resolved Hide resolved
lib/solarwinds_apm/patch/tag_sql/sw_dbo_utils.rb Show resolved Hide resolved
lib/solarwinds_apm/patch/tag_sql/sw_dbo_utils.rb Show resolved Hide resolved
lib/solarwinds_apm/patch/tag_sql/sw_pg_patch.rb Outdated Show resolved Hide resolved
test/patch/sw_pg_patch_integrate_test.rb Outdated Show resolved Hide resolved
CONFIGURATION.md Outdated Show resolved Hide resolved
cheempz
cheempz approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation and additional test @xuan-cao-swi!

@xuan-cao-swi xuan-cao-swi merged commit 2f6c615 into main Jan 8, 2025
14 checks passed
@xuan-cao-swi xuan-cao-swi deleted the NH-94970 branch January 8, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleverchuk cleverchuk cleverchuk left review comments

@cheempz cheempz cheempz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xuan-cao-swi @cheempz @cleverchuk