NH-79205 APM Python as Pure Python, OTLP HTTP by default #556

jerrytfleung · 2025-03-26T19:01:39Z

Updates APM Python to be a Pure Python library, where all signals export by OTLP HTTP by default.

This branch includes changes from 53 PRs that have each been tested.

Regular release and testing process will be followed after merging this into main.

List of all PRs

### Added

- Added ApmConfig mapping for pure Python sampler ([#552](https://github.com/solarwinds/apm-python/pull/552), [#589](https://github.com/solarwinds/apm-python/pull/589))
- Added pure Python transaction name pool ([#559](https://github.com/solarwinds/apm-python/pull/559))
- Added suppression of tracing when HTTP getSettings ([#560](https://github.com/solarwinds/apm-python/pull/560))
- Added resource detection for AWS, Azure, Kubernetes, UAMS written to resource attributes ([#577](https://github.com/solarwinds/apm-python/pull/577), [#596](https://github.com/solarwinds/apm-python/pull/596))
- Added internal deduction of export endpoint from SW_APM_COLLECTOR ([#590](https://github.com/solarwinds/apm-python/pull/590), [#602](https://github.com/solarwinds/apm-python/pull/602))

### Changed

- Updated custom transaction naming as pure Python ([#558](https://github.com/solarwinds/apm-python/pull/558))
- Simplified spankind check ([#561](https://github.com/solarwinds/apm-python/pull/561))
- Updated `http.route` assignment based on semconv ([#562](https://github.com/solarwinds/apm-python/pull/562))
- Updated to register NoOp provider if not exporting ([#566](https://github.com/solarwinds/apm-python/pull/566))
- Fixed counter metrics init ([#564](https://github.com/solarwinds/apm-python/pull/564))
- Refactored ResponseTime metrics and request counters ([#563](https://github.com/solarwinds/apm-python/pull/563), [#567](https://github.com/solarwinds/apm-python/pull/567), [#568](https://github.com/solarwinds/apm-python/pull/568))
- Fixed transaction name environment config support ([#569](https://github.com/solarwinds/apm-python/pull/569))
- Breaking: changed SolarWindsSpan Exporter to no-op for future removal ([#572](https://github.com/solarwinds/apm-python/pull/572))
- Redesigned custom Configurator ([#578](https://github.com/solarwinds/apm-python/pull/578), [#581](https://github.com/solarwinds/apm-python/pull/581))
- Updated `solarwinds_ready` API function for pure Python ([#582](https://github.com/solarwinds/apm-python/pull/582), [#584](https://github.com/solarwinds/apm-python/pull/584), [#599](https://github.com/solarwinds/apm-python/pull/599))
- Breaking: Changed default export protocol to OTLP HTTP for all signals ([#580](https://github.com/solarwinds/apm-python/pull/580))
- Updated Lambda dependencies and builds for resource detection ([#593](https://github.com/solarwinds/apm-python/pull/593))
- Fixed Configurator exporter loading to prevent ImportError ([#592](https://github.com/solarwinds/apm-python/pull/592))
- Updated smoke tests / verify_install for pure Python ([#595](https://github.com/solarwinds/apm-python/pull/595))
- Updated PyPI sdist, wheel publishes in pure Python ([#597](https://github.com/solarwinds/apm-python/pull/597))
- Breaking: Unified AWS Lambda builds for pure Python without architecture in layer name ([#594](https://github.com/solarwinds/apm-python/pull/594))
- Update autoinstrumentation-python image builds for pure Python, beta testing ([#598](https://github.com/solarwinds/apm-python/pull/598))
- Updated default OTel export header assignment for SWO vs other ([#601](https://github.com/solarwinds/apm-python/pull/601))
- Fixed HttpSampler warning message ([#604](https://github.com/solarwinds/apm-python/pull/604))
- Breaking: Updated local development setup for pure Python ([#603](https://github.com/solarwinds/apm-python/pull/603))
- Fixed `sw.w3c.tracestate` attribute assignment ([#606](https://github.com/solarwinds/apm-python/pull/606))
- Updated integration tests ([#605](https://github.com/solarwinds/apm-python/pull/605))
- Updated units, descriptions of APM counters ([#608](https://github.com/solarwinds/apm-python/pull/608))
- Updated sampler init ([#609](https://github.com/solarwinds/apm-python/pull/609))
- Updated `SW_APM_LOG_FILEPATH` support for Pure Python ([#613](https://github.com/solarwinds/apm-python/pull/613))
- Fixed tracestate KV deletion ([#617](https://github.com/solarwinds/apm-python/pull/617))

### Removed

- Breaking: removed c-lib extension and legacy components ([#549](https://github.com/solarwinds/apm-python/pull/549), [#612](https://github.com/solarwinds/apm-python/pull/612), [#614](https://github.com/solarwinds/apm-python/pull/614))
- Removed discontinued OboeAPI ([#565](https://github.com/solarwinds/apm-python/pull/565))
- Removed legacy configuration logic ([#570](https://github.com/solarwinds/apm-python/pull/570), [#571](https://github.com/solarwinds/apm-python/pull/571), [#583](https://github.com/solarwinds/apm-python/pull/583))
- Removed discontinued grpcio-using dependencies from Lambda builds ([#591](https://github.com/solarwinds/apm-python/pull/591))
- Removed warning log for Lambda mode ([#600](https://github.com/solarwinds/apm-python/pull/600))
- Removed unnecessary tests ([#611](https://github.com/solarwinds/apm-python/pull/611), [#610](https://github.com/solarwinds/apm-python/pull/610), [#615](https://github.com/solarwinds/apm-python/pull/615))
- Removed setup.py usage for builds ([#616](https://github.com/solarwinds/apm-python/pull/616))

…ect otlp) (#549) * Set a baseline for pure python implementation * Update solarwinds_apm/api/__init__.py Co-authored-by: Tammy Baylis <[email protected]> * Update solarwinds_apm/configurator.py Co-authored-by: Tammy Baylis <[email protected]> * Update solarwinds_apm/exporter.py Co-authored-by: Tammy Baylis <[email protected]> --------- Co-authored-by: Tammy Baylis <[email protected]>

* NH-104997 - Python: apm-config to Sampler Configuration mapping

… context not baggage

…sor-redesign branch (#559) * Added Transaction Name calculation logic --------- Co-authored-by: tammy-baylis-swi <[email protected]> Co-authored-by: Tammy Baylis <[email protected]>

…tsettings NH-106059 Suppress tracing when HTTP getsettings

* Housekept spantype logic

…ms-only NH-104999 Remove unnecessary param at Pure Python sampler init

NH-104999 Clean up ApmConfig unit tests

…lambda NH-103814 Don't load LambdaDetector when outside lambda

…ler-tests NH-104999 Remove legacy sampler tests

NH-108464 Add logFilepath support for Pure Python

NH-104999 Fully remove extension from linting, builds

NH-104999 Remove dead ApmConfig test fixtures

NH-23784 NH-104999 Build sdist without setup.py; use build for sdist

…state-handling NH-108869 Update sampler tracestate handling

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

tammy-baylis-swi

I huddled with @jerrytfleung to review all files. Looks good to us!

jerrytfleung

Walked through with @tammy-baylis-swi in a huddle. Looking good to us.

jerrytfleung and others added 30 commits March 20, 2025 16:55

NH-104997 - Python: apm-config to Sampler Configuration mapping (#552)

3407983

* NH-104997 - Python: apm-config to Sampler Configuration mapping

Redesign ServiceEntry caching, direct txn name sdk set_attribute, use…

4f95347

… context not baggage

NH-105550 - Added Transaction name pool logic to service-entry-proces…

4bf7369

…sor-redesign branch (#559) * Added Transaction Name calculation logic --------- Co-authored-by: tammy-baylis-swi <[email protected]> Co-authored-by: Tammy Baylis <[email protected]>

Added limit pool check on set_transaction_name API

8603932

Add default txn naming to ServiceEntry on_start (pure Python)

51e16eb

Adjusted the txn name calculator

41e895c

Suppress tracing when getSettings by http

8387e44

Fix url attr get

b725f80

Add more attr check on_start

c26f9d3

Merge pull request #560 from solarwinds/NH-106059-suppress-tracing-ge…

2d42f15

…tsettings NH-106059 Suppress tracing when HTTP getsettings

ServiceEntry default txn name based on serverless,http,name

9f4815d

Lint

1943216

Add back do-once at pool start

27fea08

TransactionName constant; custom exporter uses span.attributes

1c56918

lint

7d07264

Rm processors,manager for txn name caching and proto export

c387388

Merge branch 'pure-python' into service-entry-processor-redesign

107f6b7

lint

a42ab93

Tests - fix exporter init

3ebca28

Tests - update Processor tests

46c5b51

Tests - update TestSetTransactionName

7ac0018

Tests - rm propagator tests for rm'd helpers

5acf55a

Tests - rm txn manager fixture, update params passed

2882a7c

Fix failing calculator test

bbd6b61

lint for py3.8

cd9cda5

NH-104999 - Housekept spantype logic (#561)

905818a

* Housekept spantype logic

Lambda build no make wrapper, testrelease 4.0.0.0

e47a6f1

Debug

7be19fd

Add on_start check for AWS fn name in env

cce9b28

tammy-baylis-swi and others added 18 commits April 25, 2025 09:32

Merge pull request #609 from solarwinds/NH-104999-update-sampler-para…

abdd463

…ms-only NH-104999 Remove unnecessary param at Pure Python sampler init

Merge pull request #611 from solarwinds/NH-105347-rm-config-test-log-etc

b756494

NH-104999 Clean up ApmConfig unit tests

Merge pull request #596 from solarwinds/NH-103814-lambda-detector-in-…

509af97

…lambda NH-103814 Don't load LambdaDetector when outside lambda

Merge pull request #610 from solarwinds/NH-104999-cleanup-legacy-samp…

a25b949

…ler-tests NH-104999 Remove legacy sampler tests

Add logFilepath support for Pure Python

f2052b9

Add logFilepath tests

ccb44aa

Merge pull request #613 from solarwinds/NH-108464-log-filepath-support

6fdc1f1

NH-108464 Add logFilepath support for Pure Python

Rm extension from linting, builds

5592c71

Rm dead test fixtures

56cba9f

cleaned-up (#612)

0958528

Update comment

a6ed301

Merge pull request #614 from solarwinds/NH-104999-pure-python-setup

52d4afd

NH-104999 Fully remove extension from linting, builds

Merge pull request #615 from solarwinds/NH-104999-rm-dead-test-fixtures

ab317d6

NH-104999 Remove dead ApmConfig test fixtures

Build without setup.py; use build for sdist

371afbb

Testrelease 4.0.0.10

34b83e0

Merge pull request #616 from solarwinds/NH-23784-rm-setup-py

c824dd6

NH-23784 NH-104999 Build sdist without setup.py; use build for sdist

Update sampler tracestate handling

3e64b8b

Merge pull request #617 from solarwinds/NH-108869-update-sample-trace…

03b445b

…state-handling NH-108869 Update sampler tracestate handling

tammy-baylis-swi changed the title ~~[WIP] Pure python for reference; Don't merge~~ NH-79205 APM Python as Pure Python, OTLP HTTP by default Apr 28, 2025

tammy-baylis-swi marked this pull request as ready for review April 28, 2025 19:28

tammy-baylis-swi requested a review from a team as a code owner April 28, 2025 19:28

tammy-baylis-swi and others added 5 commits April 28, 2025 14:22

Rm pure-python from GHA

5267ae8

Rm comment

8e6f6a6

Rm comment 2

3a62454

Potential fix for code scanning alert no. 444: Unused import

4581b3d

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

Rm test unused import

d1bbb82

tammy-baylis-swi approved these changes Apr 28, 2025

View reviewed changes

jerrytfleung commented Apr 28, 2025

View reviewed changes

jerrytfleung merged commit 3226053 into main Apr 28, 2025
12 checks passed

jerrytfleung deleted the pure-python branch April 28, 2025 21:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

NH-79205 APM Python as Pure Python, OTLP HTTP by default #556

NH-79205 APM Python as Pure Python, OTLP HTTP by default #556

Uh oh!

jerrytfleung commented Mar 26, 2025 •

edited by tammy-baylis-swi

Loading

Uh oh!

tammy-baylis-swi left a comment

Uh oh!

jerrytfleung left a comment

Uh oh!

Uh oh!

Uh oh!

NH-79205 APM Python as Pure Python, OTLP HTTP by default #556

NH-79205 APM Python as Pure Python, OTLP HTTP by default #556

Uh oh!

Conversation

jerrytfleung commented Mar 26, 2025 • edited by tammy-baylis-swi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tammy-baylis-swi left a comment

Choose a reason for hiding this comment

Uh oh!

jerrytfleung left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jerrytfleung commented Mar 26, 2025 •

edited by tammy-baylis-swi

Loading