NH-97250: upgrade to upstream v2.10.0
#285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheempz
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
LGTM and thanks for the follow-ons you noted regarding gradle convention plugin @cleverchuk. Tangent: the otel sdk change makes me wonder, are we truncating the custom transaction name to 255 chars?
yessum, here. the sdk one was added because initially the lambda wouldn't go through the normal name generation path. that's has changed since the use of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed test because it's producing a false-positive. Existence of that log line doesn't necessarily mean that the class is being instrumented. For an instrumentation to actually apply to our classes it must be explicitly targeted to the relocation namespace of
com.solarwinds.joboe.*and we have tests that ensure dependencies are properly relocated to that namespace.