NH-78295 Split grpcReporter getSetting
#97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swi-jared
requested changes
May 30, 2024
swi-jared
reviewed
May 30, 2024
swi-jared
reviewed
May 30, 2024
tammy-baylis-swi
force-pushed
the
NH-78295-grpcreporter-separate-get-update-setting
branch
from
4694f6b to
d9634c3
Compare
swi-jared
approved these changes
May 30, 2024
tammy-baylis-swi
deleted the
NH-78295-grpcreporter-separate-get-update-setting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits grpcReporter's
getSettingsintogetAndUpdateSettings+getSettings+updateSettings. The reporter's ticking to periodically update oboe settings still works the same way. This is a step towards reducing reporter's current settings-related responsibilities.The rest and most of this is renaming related vars/methods for clarity.
This is pointed at
main.