Various fixes #845
Merged
Various fixes #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Metritutus
commented
Mar 10, 2024
Metritutus
commented
- Fixed debtor player linking to creditor player and vice versa on PlayerDebtForgiven event items.
- Fixed BuildCarrier and ShipTransfer components being too aggressive in ensuring default values populated the ship input boxes if the value entered was not a number. This fixes the issue where the ship input boxes could not be cleared.
- Fixed getFilteredDiplomacy() in DiplomacyService not comparing against the playerId of the player's diplomacy items. This fixes carrier waypoints not correctly taking into account whether warp scramblers on the route belonged to allies.
Solaris Release 232
…ayerDebtForgiven event items. * Fixed BuildCarrier and ShipTransfer components being too aggressive in ensuring default values populated the ship input boxes if the value entered was not a number. This fixes the issue where the ship input boxes could not be cleared. * Fixed getFilteredDiplomacy() in DiplomacyService not comparing against the playerId of the player's diplomacy items. This fixes carrier waypoints not correctly taking into account whether warp scramblers on the route belonged to allies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.