Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 251 #1383

Merged
merged 2 commits into from
Feb 15, 2025
Merged

Update 251 #1383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bc3826
Fix rank calc again
SpacialCircumstances Feb 15, 2025
acc37c2
Fix interceptor registration to only apply to created object
SpacialCircumstances Feb 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions client/src/util/http.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ export const convertDates = (obj: unknown) => {
};

export const createHttpClient = () => {
axios.create();
const client = axios.create();

axios.interceptors.response.use((response) => {
client.interceptors.response.use((response) => {
if (response.data) {
response.data = convertDates(response.data);
}
Expand All @@ -29,5 +29,5 @@ export const createHttpClient = () => {
return Promise.reject(error);
});

return axios
return client
}
2 changes: 1 addition & 1 deletion server/services/leaderboard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ export default class LeaderboardService {
}

// Apply any additional rank multiplier at the end. Rank losses are not as steep as rank gains.
const rankRewardMultiplier = rankIncrease < 0 ? Math.max(1, game.constants.player.rankRewardMultiplier) : game.constants.player.rankRewardMultiplier;
const rankRewardMultiplier = rankIncrease < 0 ? Math.min(1, game.constants.player.rankRewardMultiplier) : game.constants.player.rankRewardMultiplier;

rankIncrease *= rankRewardMultiplier;

Expand Down