Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide achievements and badges #1337

Merged
merged 1 commit into from
Jan 25, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions server/services/achievement.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import Repository from "./repository";
import { User } from "./types/User";
import GuildService from "./guild";
import UserLevelService from "./userLevel";
import {nullObject} from "./utils";

export default class AchievementService {

Expand Down Expand Up @@ -32,6 +33,19 @@ export default class AchievementService {
user.level = this.userLevelService.getByRankPoints(user.achievements.rank);
}

// TODO: Fix this properly

if (user?.achievements) {
nullObject(user.achievements.combat.kills);
nullObject(user.achievements.combat.homeStars);
nullObject(user.achievements.combat.losses);
nullObject(user.achievements.combat.stars);
nullObject(user.achievements.badges);
nullObject(user.achievements.infrastructure);
nullObject(user.achievements.trade);
nullObject(user.achievements.research);
}

if (user && user.guildId) {
return {
...user,
Expand Down
10 changes: 9 additions & 1 deletion server/services/badge.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ export default class BadgeService extends EventEmitter {
}

async listBadgesByUser(userId: DBObjectId): Promise<UserBadge[]> {
return [];

/*
const badges = this.listBadges();

const user = await this.userService.getById(userId, {
Expand All @@ -58,10 +61,13 @@ export default class BadgeService extends EventEmitter {
});
}

return userBadges.filter(b => b.awarded);
return userBadges.filter(b => b.awarded);*/
}

async listBadgesByPlayer(game: Game, playerId: DBObjectId) {
return [];

/*
let player = this.playerService.getById(game, playerId);

if (!player) {
Expand All @@ -78,6 +84,8 @@ export default class BadgeService extends EventEmitter {
}

return await this.listBadgesByUser(player.userId);

*/
}

async purchaseBadgeForUser(purchasedByUserId: DBObjectId, purchasedForUserId: DBObjectId, badgeKey: string) {
Expand Down
6 changes: 6 additions & 0 deletions server/services/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,4 +63,10 @@ export function shuffle<T>(rand: RandomGen, a: Array<T>) {
[a[i], a[j]] = [a[j], a[i]];
}
return a;
}

export const nullObject = (obj: Object) => {
for (let key of Object.keys(obj)) {
obj[key] = 0;
}
}
Loading