Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Updated gameConversationRead() method in BroadcastService to not br… #1329

Merged
merged 1 commit into from
Jan 20, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions server/services/broadcast.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,10 @@ export default class BroadcastService {
}

gameConversationRead(game: Game, conversation: Conversation, readByPlayerId: DBObjectId) {
conversation.participants.forEach(p => this.playerServerSocketEmitter.emitGameConversationRead(p.toString(), {
this.playerServerSocketEmitter.emitGameConversationRead(readByPlayerId.toString(), {
conversationId: conversation._id.toString(),
readByPlayerId: readByPlayerId.toString()
}));
});
}

gameConversationLeft(game: Game, conversation: Conversation, playerId: DBObjectId) {
Expand Down
9 changes: 9 additions & 0 deletions server/services/conversation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,15 @@ export default class ConversationService extends EventEmitter {
throw new ValidationError(`You are not participating in this conversation.`);
}

convo.messages.forEach(cm => {
cm = <ConversationMessage>cm;
cm.readBy = cm.readBy.filter(pid => pid.toString() === playerId.toString());
})

if (convo.lastMessage != null) {
convo.lastMessage.readBy = convo.lastMessage.readBy.filter(pid => pid.toString() === playerId.toString());
}

return convo;
}

Expand Down
Loading