Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix side effects of bulk upgrade report causing issues #1056

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Fix side effects of bulk upgrade report causing issues #1056

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions server/services/scheduleBuy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,7 @@ export default class ScheduleBuyService extends EventEmitter {
// When players schedule actions to spend more credits than they have, we spend all their credits
action.amount = player.credits
}
const report = await this.starUpgradeService.generateUpgradeBulkReport(game, player, action.buyType, action.infrastructureType, action.amount);
if (report.cost > player.credits) {
// If the player does not have enough credits, we do not buy anything.
continue;
}

await this.starUpgradeService.upgradeBulk(game, player, action.buyType, action.infrastructureType, action.amount, false);
} catch (e) {
console.error(e)
Expand Down
Loading