-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Conversation
Need to update https://github.com/solana-labs/solana/blob/master/ci/coverage.sh#L13 as well |
c610a47
to
ec0edc6
Compare
Hey @mvines, I can't seem to reproduce the nightly build within docker on macos. It gets stuck compiling pnet_transport when installing cargo-cov. In CI, this build fails because gcov fails, which is called by the codecov bash script. To fix, we probably need a gcov version that matches Rust's coverage instrumentation. The cargo-cov repo suggests installing |
The problem is that the codecov tool is trying to use |
Or you could try this "hack": codecov/codecov-bash#55 (comment) (with latest llvm-cov, not llvm-cov-3.8). |
9b5061c
to
94b1c43
Compare
Codecov Report
@@ Coverage Diff @@
## master #378 +/- ##
=======================================
Coverage 91.34% 91.34%
=======================================
Files 36 36
Lines 3583 3583
=======================================
Hits 3273 3273
Misses 310 310 Continue to review full report at Codecov.
|
@marco-c called this a hack, but since grcov isn't working out-of-the-box (panics on call to gcov), we'll take a stab at using llvm-cov.
(to use grcov with Rust-generated files you need to pass the |
Thanks @marco-c, I confirmed that adding the |
) Bumps [@babel/cli](https://github.com/babel/babel/tree/HEAD/packages/babel-cli) from 7.10.5 to 7.11.5. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.11.5/packages/babel-cli) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Fixes #177
Thanks @marco-c!