Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SanitizedMessage::try_from to try_from_legacy_message #35338

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

jstarry
Copy link
Member

@jstarry jstarry commented Feb 28, 2024

Problem

TryFrom only supports a single argument, but in #34901, SanitizedMessage will need an additional parameter for reserved account keys.

Summary of Changes

Rename SanitizedMessage::try_from to try_from_legacy_message

Note that the only non test/bench uses of the changed method are in banks-server and banks-client

Fixes #

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 99.13793% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.7%. Comparing base (da08868) to head (d58b00c).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #35338     +/-   ##
=========================================
- Coverage    81.7%    81.7%   -0.1%     
=========================================
  Files         834      834             
  Lines      224244   224309     +65     
=========================================
- Hits       183398   183392      -6     
- Misses      40846    40917     +71     

@jstarry jstarry merged commit 312f786 into solana-labs:master Feb 29, 2024
45 checks passed
@jstarry jstarry deleted the refactor/from-legacy-message branch February 29, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants