This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Add gossip notifications / cluster node notifications to geyser #34618
Closed
musitdev
wants to merge
3
commits into
solana-labs:v1.17
from
musitdev:add_cluster_info_on_geyzer_1.17.5
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -2,6 +2,8 @@ | |||
/// the GeyserPlugin trait to work with the runtime. | ||||
/// In addition, the dynamic library must export a "C" function _create_plugin which | ||||
/// creates the implementation of the plugin. | ||||
use solana_sdk::pubkey::Pubkey; | ||||
use std::net::SocketAddr; | ||||
use { | ||||
solana_sdk::{ | ||||
clock::{Slot, UnixTimestamp}, | ||||
|
@@ -13,6 +15,36 @@ use { | |||
thiserror::Error, | ||||
}; | ||||
|
||||
#[derive(Debug, Clone, PartialEq, Eq)] | ||||
/// Information about a node in the cluster. | ||||
pub struct ReplicaClusterInfoNode { | ||||
pub id: Pubkey, | ||||
/// gossip address | ||||
pub gossip: Option<SocketAddr>, | ||||
/// address to connect to for replication | ||||
pub tvu: Option<SocketAddr>, | ||||
/// TVU over QUIC protocol. | ||||
pub tvu_quic: Option<SocketAddr>, | ||||
/// repair service over QUIC protocol. | ||||
pub serve_repair_quic: Option<SocketAddr>, | ||||
/// transactions address | ||||
pub tpu: Option<SocketAddr>, | ||||
/// address to forward unprocessed transactions to | ||||
pub tpu_forwards: Option<SocketAddr>, | ||||
/// address to which to send bank state requests | ||||
pub tpu_vote: Option<SocketAddr>, | ||||
/// address to which to send JSON-RPC requests | ||||
pub rpc: Option<SocketAddr>, | ||||
/// websocket for JSON-RPC push notifications | ||||
pub rpc_pubsub: Option<SocketAddr>, | ||||
/// address to send repair requests to | ||||
pub serve_repair: Option<SocketAddr>, | ||||
/// latest wallclock picked | ||||
pub wallclock: u64, | ||||
/// node shred version | ||||
pub shred_version: u16, | ||||
} | ||||
|
||||
#[derive(Debug, Clone, PartialEq, Eq)] | ||||
/// Information about an account being updated | ||||
pub struct ReplicaAccountInfo<'a> { | ||||
|
@@ -317,6 +349,18 @@ pub trait GeyserPlugin: Any + Send + Sync + std::fmt::Debug { | |||
Ok(()) | ||||
} | ||||
|
||||
/// Called when a cluster info is updated on gossip network. | ||||
#[allow(unused_variables)] | ||||
fn update_cluster_info(&self, cluster_info: &ReplicaClusterInfoNode) -> Result<()> { | ||||
Ok(()) | ||||
} | ||||
|
||||
/// Called when a cluster info is removed on gossip network. | ||||
#[allow(unused_variables)] | ||||
fn notify_clusterinfo_remove(&self, pubkey: &Pubkey) -> Result<()> { | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When is this called? notify_clusterinfo_remove? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can find the call here: Line 554 in f4bc1be
|
||||
Ok(()) | ||||
} | ||||
|
||||
/// Called when all accounts are notified of during startup. | ||||
fn notify_end_of_startup(&self) -> Result<()> { | ||||
Ok(()) | ||||
|
@@ -375,4 +419,11 @@ pub trait GeyserPlugin: Any + Send + Sync + std::fmt::Debug { | |||
fn entry_notifications_enabled(&self) -> bool { | ||||
false | ||||
} | ||||
|
||||
/// Check if the plugin is interested in cluster info data | ||||
/// Default is false -- if the plugin is interested in | ||||
/// cluster info data, return true. | ||||
fn clusterinfo_notifications_enabled(&self) -> bool { | ||||
false | ||||
} | ||||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,153 @@ | ||
/// Module responsible for notifying plugins of transactions | ||
use solana_gossip::legacy_contact_info::LegacyContactInfo; | ||
use solana_sdk::pubkey::Pubkey; | ||
use { | ||
crate::geyser_plugin_manager::GeyserPluginManager, | ||
log::*, | ||
solana_client::connection_cache::Protocol, | ||
solana_geyser_plugin_interface::geyser_plugin_interface::ReplicaClusterInfoNode, | ||
solana_gossip::cluster_info_notifier_interface::ClusterInfoNotifierInterface, | ||
solana_measure::measure::Measure, | ||
solana_metrics::*, | ||
solana_rpc::transaction_notifier_interface::TransactionNotifier, | ||
solana_sdk::{clock::Slot, signature::Signature, transaction::SanitizedTransaction}, | ||
solana_transaction_status::TransactionStatusMeta, | ||
std::sync::{Arc, RwLock}, | ||
}; | ||
|
||
/// This implementation of ClusterInfoNotifierImpl is passed to the rpc's TransactionStatusService | ||
/// at the validator startup. TransactionStatusService invokes the notify_transaction method | ||
/// for new transactions. The implementation in turn invokes the notify_transaction of each | ||
/// plugin enabled with transaction notification managed by the GeyserPluginManager. | ||
#[derive(Debug)] | ||
pub(crate) struct ClusterInfoNotifierImpl { | ||
plugin_manager: Arc<RwLock<GeyserPluginManager>>, | ||
} | ||
|
||
impl ClusterInfoNotifierImpl { | ||
pub fn new(plugin_manager: Arc<RwLock<GeyserPluginManager>>) -> Self { | ||
ClusterInfoNotifierImpl { plugin_manager } | ||
} | ||
|
||
fn clusterinfo_from_legacy_contact_info( | ||
legacy_info: &LegacyContactInfo, | ||
) -> ReplicaClusterInfoNode { | ||
ReplicaClusterInfoNode { | ||
id: *legacy_info.pubkey(), | ||
/// gossip address | ||
gossip: legacy_info.gossip().ok(), | ||
/// address to connect to for replication | ||
tvu: legacy_info.tvu(Protocol::UDP).ok(), | ||
/// TVU over QUIC protocol. | ||
tvu_quic: legacy_info.tvu(Protocol::QUIC).ok(), | ||
/// repair service over QUIC protocol. | ||
serve_repair_quic: legacy_info.serve_repair(Protocol::QUIC).ok(), | ||
/// transactions address | ||
tpu: legacy_info.tpu(Protocol::UDP).ok(), | ||
/// address to forward unprocessed transactions to | ||
tpu_forwards: legacy_info.tpu_forwards(Protocol::UDP).ok(), | ||
/// address to which to send bank state requests | ||
tpu_vote: legacy_info.tpu_vote().ok(), | ||
/// address to which to send JSON-RPC requests | ||
rpc: legacy_info.rpc().ok(), | ||
/// websocket for JSON-RPC push notifications | ||
rpc_pubsub: legacy_info.rpc_pubsub().ok(), | ||
/// address to send repair requests to | ||
serve_repair: legacy_info.serve_repair(Protocol::UDP).ok(), | ||
/// latest wallclock picked | ||
wallclock: legacy_info.wallclock(), | ||
/// node shred version | ||
shred_version: legacy_info.shred_version(), | ||
} | ||
} | ||
} | ||
|
||
impl ClusterInfoNotifierInterface for ClusterInfoNotifierImpl { | ||
fn notify_clusterinfo_update(&self, contact_info: &LegacyContactInfo) { | ||
let cluster_info = | ||
ClusterInfoNotifierImpl::clusterinfo_from_legacy_contact_info(contact_info); | ||
let mut measure2 = Measure::start("geyser-plugin-notify_plugins_of_cluster_info_update"); | ||
let plugin_manager = self.plugin_manager.read().unwrap(); | ||
|
||
if plugin_manager.plugins.is_empty() { | ||
return; | ||
} | ||
for plugin in plugin_manager.plugins.iter() { | ||
let mut measure = Measure::start("geyser-plugin-update-cluster_info"); | ||
match plugin.update_cluster_info(&cluster_info) { | ||
Err(err) => { | ||
error!( | ||
"Failed to update cluster_info {}, error: {} to plugin {}", | ||
bs58::encode(cluster_info.id).into_string(), | ||
err, | ||
plugin.name() | ||
) | ||
} | ||
Ok(_) => { | ||
trace!( | ||
"Successfully updated cluster_info {} to plugin {}", | ||
bs58::encode(cluster_info.id).into_string(), | ||
plugin.name() | ||
); | ||
} | ||
} | ||
measure.stop(); | ||
inc_new_counter_debug!( | ||
"geyser-plugin-update-cluster_info-us", | ||
measure.as_us() as usize, | ||
100000, | ||
100000 | ||
); | ||
} | ||
measure2.stop(); | ||
inc_new_counter_debug!( | ||
"geyser-plugin-notify_plugins_of_cluster_info_update-us", | ||
measure2.as_us() as usize, | ||
100000, | ||
100000 | ||
); | ||
} | ||
|
||
fn notify_clusterinfo_remove(&self, pubkey: &Pubkey) { | ||
let mut measure2 = Measure::start("geyser-plugin-notify_plugins_of_cluster_info_update"); | ||
let plugin_manager = self.plugin_manager.read().unwrap(); | ||
|
||
if plugin_manager.plugins.is_empty() { | ||
return; | ||
} | ||
for plugin in plugin_manager.plugins.iter() { | ||
let mut measure = Measure::start("geyser-plugin-remove-cluster_info"); | ||
match plugin.notify_clusterinfo_remove(pubkey) { | ||
Err(err) => { | ||
error!( | ||
"Failed to remove cluster_info {}, error: {} to plugin {}", | ||
bs58::encode(pubkey).into_string(), | ||
err, | ||
plugin.name() | ||
) | ||
} | ||
Ok(_) => { | ||
trace!( | ||
"Successfully remove cluster_info {} to plugin {}", | ||
bs58::encode(pubkey).into_string(), | ||
plugin.name() | ||
); | ||
} | ||
} | ||
measure.stop(); | ||
inc_new_counter_debug!( | ||
"geyser-plugin-remove-cluster_info-us", | ||
measure.as_us() as usize, | ||
100000, | ||
100000 | ||
); | ||
} | ||
measure2.stop(); | ||
inc_new_counter_debug!( | ||
"geyser-plugin-notify_plugins_of_cluster_info_remove-us", | ||
measure2.as_us() as usize, | ||
100000, | ||
100000 | ||
); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow our coding style, put them in "use {...}";
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected