Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a number of typos #34385

Merged
merged 24 commits into from
Dec 12, 2023
Merged

Fix a number of typos #34385

merged 24 commits into from
Dec 12, 2023

Conversation

pandabadger
Copy link
Contributor

Problem

Fix a number of typos

Summary of Changes

Mostly in docs and a couple of comments

Fixes #

@mergify mergify bot added community Community contribution need:merge-assist labels Dec 10, 2023
@mergify mergify bot requested a review from a team December 10, 2023 01:23
Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Just one suggestion.

docs/src/implemented-proposals/staking-rewards.md Outdated Show resolved Hide resolved
@CriesofCarrots CriesofCarrots added the CI Pull Request is ready to enter CI label Dec 11, 2023
@solana-grimes solana-grimes removed the CI Pull Request is ready to enter CI label Dec 11, 2023
CriesofCarrots
CriesofCarrots previously approved these changes Dec 11, 2023
Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #34385 (2acfc33) into master (aab12c3) will decrease coverage by 0.1%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #34385     +/-   ##
=========================================
- Coverage    81.9%    81.8%   -0.1%     
=========================================
  Files         819      819             
  Lines      220977   220977             
=========================================
- Hits       181011   180946     -65     
- Misses      39966    40031     +65     

@CriesofCarrots
Copy link
Contributor

Some of these docs were just moved to a different repo. Fixes made in this PR to those files should be reflected here: solana-foundation/developer-content#34

Copy link
Contributor

@nickfrosty nickfrosty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@nickfrosty nickfrosty merged commit 549c3e7 into solana-labs:master Dec 12, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution need:merge-assist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants