This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Document lockout_intervals and tiny niceties #10925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryoqun
commented
Jul 6, 2020
| @@ -14,7 +14,9 @@ use std::{ | |||
| sync::{Arc, RwLock}, | |||
| }; | |||
|
|
|||
| pub(crate) type LockoutIntervals = BTreeMap<Slot, Vec<(Slot, Rc<Pubkey>)>>; | |||
| type VotedSlot = Slot; | |||
There was a problem hiding this comment.
Even if I say this, rustc still use u64 due to rust-lang/rust#17164. But better than nothing. :)
Codecov Report
@@ Coverage Diff @@
## master #10925 +/- ##
=======================================
Coverage 82.0% 82.0%
=======================================
Files 310 310
Lines 71884 71884
=======================================
+ Hits 58949 58954 +5
+ Misses 12935 12930 -5 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
lockout_intervals's data shape is a bit unusual.Summary of Changes
Document it and extra some niceties.
No functional change.
Context: #10718