jit: add support for aarch64 #358
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add feature flag for new JIT support
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #358 +/- ##
===========================================
- Coverage 90.21% 74.81% -15.41%
===========================================
Files 21 24 +3
Lines 8312 10080 +1768
===========================================
+ Hits 7499 7541 +42
- Misses 813 2539 +1726 ☔ View full report in Codecov by Sentry. |
|
Differential fuzzing this with the interpreter for 24 hours. I'll let you know if I find anything. |
|
No detected misbehaviour from fuzzing. I've DM'd you already about some of the other issues. |
|
Hi, I'm trying to build the ARM64 target with solana latest release, but i'm not sure if this PR cloud be merge can resolve the build error in solana? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contribution is on behalf of Trail of Bits.
This adds support for aarch64 code generation to the JIT. This refactors the architecture-specific code emission parts of the existing x86 JIT into a new JitCompilerX86 struct, which adopts a new JitCompilerImpl trait.
The aarch64 JIT was modeled closely after the x86 JIT. Although all tests pass, the new aarch64 JIT is not ready for production use, and is gated behind a feature flag:
jit-aarch64-not-safe-for-production.