Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tony/metaplex-core-voter #103

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

tonyboylehub
Copy link

No description provided.

@crypt0miester crypt0miester self-assigned this Aug 12, 2024
@crypt0miester
Copy link
Collaborator

gm team,

apart from the reviewed comments, please do the following:

  • Add programs/core-voter to the root Cargo.toml
  • Add refreshing the blockhash periodically, because I've been getting RpcError(DeadlineExceeded) and some times IoError(Custom { kind: Other, error: "the request exceeded its deadline" }). for reference: link
  • update_voter_weight_record.rs tests are failing. Please revisit.
  • please run cargo clippy -- -A clippy::pedantic --deny=warnings and cargo fmt -- --check
  • rename the file programs/core-voter/src/instructions/udpate_max_voter_weight_record.rs please

regards,
miester

.unwrap();

// The weight never expires and only changes when collections are configured
max_voter_weight_record.max_voter_weight_expiry = None;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since, update_max_voter_weight_record will take care of the max voter weight,configure_collection should reset the fields on MaxVoterWeightRecord:

    max_voter_weight_record.max_voter_weight = 0;
    max_voter_weight_record.max_voter_weight_expiry = Some(0);

Setting it to None will bypass the slot check if update_max_voter_weight_record is not called.

@tonyboylehub
Copy link
Author

Just picking back up on this, apologise we were away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants