score-all command #119
Open
score-all command #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* make stake pool optional, score-all command * generate validator-detail.csv * skip heavy rpc-call, ensure all validators scored * compute score * scripts * parametrize score, do not combine with --confirm * fix score-all arguments
mvines
reviewed
Jul 5, 2021
bot/src/db.rs
Outdated
Comment on lines
33
to
39
| /// computed score (more granular than ValidatorStakeState) | ||
| pub epoch_credits: u64, // epoch_credits is the base score | ||
| pub score_discounts: ScoreDiscounts, | ||
| pub commission: u8, | ||
| pub active_stake: u64, | ||
| pub data_center_concentration: f64, | ||
|
|
There was a problem hiding this comment.
In order to avoid breaking the existing database entries, the new fields here need to each be wrapped in an Option<>. You might find it easier to move them all out into a single struct and wrap an Option around just that struct
mvines
reviewed
Jul 5, 2021
| @@ -196,6 +196,15 @@ struct Config { | |||
|
|
|||
| dry_run: bool, | |||
|
|
|||
| /// compute score foll all validators in the cluster | |||
| score_all: bool, | |||
There was a problem hiding this comment.
How about rebasing this PR on #118, where we add a Command enum to avoid adding command-specific (ScoreAll in this case) parameters into the Config struct
| @@ -293,7 +306,9 @@ impl Config { | |||
| } | |||
|
|
|||
| fn cluster_db_path_for(&self, cluster: Cluster) -> PathBuf { | |||
| self.db_path.join(format!("data-{}", cluster)) | |||
| // store db on different dir for score-all to not mess with SPL-stake-pool distribution usage | |||
| let dir = if self.score_all { "score-all" } else { "data" }; | |||
There was a problem hiding this comment.
Can we avoid this change by making the db.rs changes backwards compatible ?
bot/src/main.rs
Outdated
| continue; | ||
| } | ||
|
|
||
| /* -- ------------------ |
There was a problem hiding this comment.
Please remove this comment block
|
making some changes, will fix based on recommendations after our launch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make stake pool optional, score-all command
generate validator-detail.csv
skip heavy rpc-call, ensure all validators scored
compute score
scripts
parametrize score, do not combine with --confirm
fix score-all arguments