Add apostrophe to inanimate possessive object #506
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines 78 - 80 of CONTRIBUTING.md state:
Use apostrophes of possession,
[including for inanimate objects](https://english.stackexchange.com/questions/1031/is-using-the-possessive-s-correct-in-the-cars-antenna).
Eg 'the account's balance' is correct.
nickfrosty
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Lines 78 - 80 of CONTRIBUTING.md state:
Use apostrophes of possession,
including for inanimate objects.
Eg 'the account's balance' is correct.
But lines 87 - 88 seem to be missing the possessive apostrophe for "functions handler."
Summary of Changes
Add possessive apostrophe for "function's handler," assuming that functions in Anchor are defined in a way that specifies how to handle the instructions sent from clients. However, I am not certain that I am interpreting the documentation accurately, and the existing "functions handler" might be contextually accurate.
Maybe it would be clearer to say something like, "The
multiple files templatein Anchor also calls each defined function's respectivehandler."