Updated NFTs with Metaplex lesson #503
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikemaccana
suggested changes
Oct 7, 2024
| ), | ||
| ); | ||
|
|
||
| const user = Keypair.fromSecretKey(new Uint8Array(walletFile)); |
There was a problem hiding this comment.
Why not just use await getKeypairFromFile();? This PR makes the process of loading a keypair more complicated.
| @@ -147,17 +153,17 @@ computer. | |||
| In action, uploading an image named `random-image.png` from your computer would | |||
| take the following steps: | |||
|
|
|||
| 1. Reading the file using `readFile` into a buffer. | |||
| 1. Reading the file using `readFileSync` into a buffer. | |||
There was a problem hiding this comment.
node,js generally prefers async code rather than blocking code.
|
|
||
| const buffer = await fs.readFile(filePath); | ||
| const buffer = await fs.readFileSync(filePath); |
There was a problem hiding this comment.
As mentioned in README.md we prefer async/await.
| @@ -345,7 +355,7 @@ Solana. | |||
| To begin, make a new folder and install the relevant dependencies: | |||
|
|
|||
| ```bash | |||
| npm i @solana/web3.js npm i @solana/web3.js npm i @solana-developers/helpers npm i @metaplex-foundation/mpl-token-metadata npm i @metaplex-foundation/umi-bundle-defaults npm i @metaplex-foundation/umi-uploader-irys npm i --save-dev esrun | |||
| npm i @solana/web3.js npm i @metaplex-foundation/mpl-token-metadata npm i @metaplex-foundation/umi-bundle-defaults npm i @metaplex-foundation/umi-uploader-irys npm i --save-dev esrun | |||
There was a problem hiding this comment.
You are removing helpers for no reason. See CONTRIBUTING.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Outdated Tokens with Metaplex lessons
Summary of Changes
Updated code snippets with the latest dependencies and official Metaplex coding conventions
Fixed some grammar issues in the lesson
Fixed as per guidelines
Removed outdated dependencies and replaced them with the latest versions, and everything is working fine as expected
@mikemaccana