Connecting to offchain data - Updated Oracles lesson #495

0xCipherCoder · 2024-09-21T20:00:02Z

Problem

Summary of Changes

Updated code snippets with the latest anchor and switchboard-solana version
Fixed content with updated version changes
Fixed grammar and styling
Fixed as per guidelines

Fixes #
Unboxed PRs
Burry Escrow code updated - solana-developers/burry-escrow#4

@mikemaccana I need your help in creating an additional branch for the challenge solution.

… into fix-connecting-to-offchain-data-oracles

mikemaccana

Just small changes and formatting, plus I need some help understanding the tests. See. above.

mikemaccana · 2024-09-24T04:20:36Z

content/courses/connecting-to-offchain-data/oracles.md

+Solana has a rich ecosystem of oracle providers. Some notable ones include
+[Pyth Network](https://pyth.network), [Switchboard](https://switchboard.xyz),
+[Chainlink](https://chain.link), and
+[DIA](https://www.diadata.org/solana-price-oracles/). Two of the most well-known
+are [Pyth](https://pyth.network) and [Switchboard](https://switchboard.xyz),
+each with unique design choices.


There's some duplication here from the old text. I suggest:

Solana has a rich ecosystem of oracle providers. Some notable ones include: - [**Pyth**](https://www.pyth.network/price-feeds) ... - [**Switchboard**](https://example.com) ... - [**Chainlink**](https://example.com) ... - [DIA](https://www.diadata.org/solana-price-oracles/) ... We'll use Switchboard in this lesson, but the concepts are common to most oracles and you should pick the oracle that best meets your needs.

Yes resolved as per suggestion.

Sorry @0xCipherCoder I should be more specific.

Don't do:

some text - Pyth - Switchboard - Chainlink - Dia some text - Pyth - Switchboard

Instead, replace all of that with:

some text - Pyth - Switchboard - Chainlink - Dia

I hope that makes sense.

Just curious should we then remove description that has been given again for Pyth and Switchboard? Just keep the original oneliner description then go ahead with switchboard.

Remove the second list, keep all the information (including more detailed explanations for Python and switchboard) but use a single list.

Updated content list as per suggestion.

content/courses/connecting-to-offchain-data/oracles.md

mikemaccana · 2024-09-24T04:40:20Z

content/courses/connecting-to-offchain-data/oracles.md

-    // derive escrow address
-    const [escrowState] = await anchor.web3.PublicKey.findProgramAddressSync(
-      [Buffer.from("MICHAEL BURRY"), payer.publicKey.toBuffer()],
+  it("fails to withdraw while price is below UnlockPrice", async () => {


I don't understand how this works, precisely how we are simulating the current price of SOL to be able to test this. Can you explain it to me?

@mikemaccana Here is the explainer - Anchor Toml reference -
The test environment clones the Switchboard SOL/USD price feed from the devnet to the local test validator.
This cloned feed maintains its last known state, providing a fixed, realistic SOL price for the tests.
Then tests interact with this local copy of the feed, fetching the SOL price as if it were live data.
While the price doesn't update in real time, it allows consistent testing against a known SOL price point. In essence, we are working with a "snapshot" of the real SOL price feed, frozen at the time of cloning when we start testing with anchor test command. For this to work we have added an additional config in Anchor.toml file -

[test] startup_wait = 5000 shutdown_wait = 2000 upgradeable = false [test.validator] bind_address = "0.0.0.0" url = "https://api.devnet.solana.com" ledger = ".anchor/test-ledger" rpc_port = 8899 [[test.validator.clone]] # switchboard-solana devnet programID address = "SW1TCH7qEPTdLsDHRgPuMQjbQxKdH2aBStViMFnt64f" [[test.validator.clone]] # switchboard-solana devnet IDL address = "Fi8vncGpNKbq62gPo56G4toCehWNy77GgqGkTaAF5Lkk" # This clones the SOL/USD price feed from devnet to local test validator. [[test.validator.clone]] # switchboard-solana SOL/USD Feed address = "GvDMxPzN1sCj7L26YDK2HnMRXEQmQ2aemov8YBtPS7vR"

This PublicKey used in tests corresponds to the cloned feed in a local environment.

const SOL_USD_SWITCHBOARD_FEED = new PublicKey( "GvDMxPzN1sCj7L26YDK2HnMRXEQmQ2aemov8YBtPS7vR" );

Let me know if you still have doubts.

I understand account cloning, but I don't understand why
it withdraws from escrow and it fails to withdraw while price is below UnlockPrice both pass when SOL_USD_SWITCHBOARD_FEED is not changing.

Okay got the concerns. Although SOL_USD_SWITCHBOARD_FEED is not changing we are changing the price in test as given below to simulate the escrow behaviour.

const unlockPrice = solPrice.plus(PRICE_OFFSET).toNumber();

Aha! Can you please add a comment in the tests to say this?

Yes added comments in both tests.

mikemaccana

Getting very close, see two comments below.

mikemaccana · 2024-09-24T10:06:48Z

content/courses/connecting-to-offchain-data/oracles.md

+Solana has a rich ecosystem of oracle providers. Some notable ones include
+[Pyth Network](https://pyth.network), [Switchboard](https://switchboard.xyz),
+[Chainlink](https://chain.link), and
+[DIA](https://www.diadata.org/solana-price-oracles/). Two of the most well-known
+are [Pyth](https://pyth.network) and [Switchboard](https://switchboard.xyz),
+each with unique design choices.


Sorry @0xCipherCoder I should be more specific.

Don't do:

some text - Pyth - Switchboard - Chainlink - Dia some text - Pyth - Switchboard

Instead, replace all of that with:

some text - Pyth - Switchboard - Chainlink - Dia

I hope that makes sense.

content/courses/connecting-to-offchain-data/oracles.md

mikemaccana · 2024-09-24T10:12:24Z

content/courses/connecting-to-offchain-data/oracles.md

-    // derive escrow address
-    const [escrowState] = await anchor.web3.PublicKey.findProgramAddressSync(
-      [Buffer.from("MICHAEL BURRY"), payer.publicKey.toBuffer()],
+  it("fails to withdraw while price is below UnlockPrice", async () => {


I understand account cloning, but I don't understand why
it withdraws from escrow and it fails to withdraw while price is below UnlockPrice both pass when SOL_USD_SWITCHBOARD_FEED is not changing.

mikemaccana · 2024-09-24T11:38:20Z

Thanks @0xCipherCoder !

Updated content and code snippets

8c3adfa

0xCipherCoder requested a review from mikemaccana as a code owner September 21, 2024 20:00

0xCipherCoder mentioned this pull request Sep 21, 2024

Native onchain development - Updated hello world lesson #401

Merged

0xCipherCoder added 10 commits September 22, 2024 08:12

Improved tests

7f10a0a

Resovled comments

75d1c37

Merge branch 'main' of github.com:solana-foundation/developer-content…

eb94820

… into fix-connecting-to-offchain-data-oracles

Resovled comments

a20d3f3

Fixed conflicts

e4ea0d7

Updated oracles info

7330708

Updated content for oracle list

0334f8a

Merge branch 'main' of github.com:solana-foundation/developer-content…

c8ec74a

… into fix-connecting-to-offchain-data-oracles

Updated comments for escrow unlock price

ca75d61

Updated content for oracle list

a952f63

mikemaccana suggested changes Sep 24, 2024

View reviewed changes

mikemaccana added the superteam-lesson-updates label Sep 24, 2024

0xCipherCoder requested a review from nickfrosty as a code owner September 24, 2024 08:06

mikemaccana suggested changes Sep 24, 2024

View reviewed changes

mikemaccana approved these changes Sep 24, 2024

View reviewed changes

mikemaccana merged commit 3c1633e into solana-foundation:main Sep 24, 2024
2 checks passed

mikemaccana added the superteam-winner label Sep 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Connecting to offchain data - Updated Oracles lesson #495

Connecting to offchain data - Updated Oracles lesson #495

0xCipherCoder commented Sep 21, 2024 •

edited

Loading

mikemaccana left a comment

mikemaccana Sep 24, 2024

0xCipherCoder Sep 24, 2024

mikemaccana Sep 24, 2024

0xCipherCoder Sep 24, 2024

mikemaccana Sep 24, 2024 •

edited

Loading

0xCipherCoder Sep 24, 2024

mikemaccana Sep 24, 2024

0xCipherCoder Sep 24, 2024

mikemaccana Sep 24, 2024

0xCipherCoder Sep 24, 2024

mikemaccana Sep 24, 2024

0xCipherCoder Sep 24, 2024

mikemaccana left a comment •

edited

Loading

mikemaccana Sep 24, 2024

mikemaccana Sep 24, 2024

mikemaccana commented Sep 24, 2024 •

edited

Loading

Connecting to offchain data - Updated Oracles lesson #495

Connecting to offchain data - Updated Oracles lesson #495

Conversation

0xCipherCoder commented Sep 21, 2024 • edited Loading

Problem

Summary of Changes

mikemaccana left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mikemaccana Sep 24, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mikemaccana left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mikemaccana commented Sep 24, 2024 • edited Loading

0xCipherCoder commented Sep 21, 2024 •

edited

Loading

mikemaccana Sep 24, 2024 •

edited

Loading

mikemaccana left a comment •

edited

Loading

mikemaccana commented Sep 24, 2024 •

edited

Loading