Updated Verifiable Randomness Functions #481

nandanpathakk · 2024-09-12T19:19:20Z

Summary of Changes

Updated content to align with the guide.
Improved clarity in instructions and code examples.
Fixed grammatical errors.
Updated and corrected broken or outdated links.

mikemaccana

This has some good changes but what's bs-switchboard-solana?

mikemaccana · 2024-10-13T07:31:17Z

content/courses/connecting-to-offchain-data/verifiable-randomness-functions.md

@@ -301,35 +306,35 @@ context.

 - `authority` - PDA derived from our program
 - `vrf` -
-  [Account owned by the Switchboard program](https://docs.rs/switchboard-solana/latest/switchboard_solana/oracle_program/accounts/vrf/struct.VrfAccountData.html)
+  [Account owned by the Switchboard program](https://docs.rs/bs-switchboard-solana/latest/switchboard_solana/oracle_program/accounts/vrf/struct.VrfAccountData.html)


What is bs-switchboard-solana? It looks like an odd fork and its version is 0.0.0

mikemaccana

This is an excellent contribution, thanks @nandanpathakk ! You have an excellent eye for detail. While you didn't win this lesson, we'd love to get this in - there's a few small changes required but you're 95% of the way there. Please see the comments below and I'll get this in once they're done!

mikemaccana · 2024-10-13T07:35:51Z

content/courses/connecting-to-offchain-data/verifiable-randomness-functions.md

-external data and service requests onchain. To learn more about Switchboard’s
-Oracle network, please refer to our
+composed of many individual oracles run by third parties, which provide external
+data and service requests onchain. To learn more about Switchboard’s Oracle


This is an error in the old material, but 'oracle' is a concept and should be lowercase (I think people may be confused with the database company). Fix this everywhere please!

mikemaccana · 2024-10-13T07:37:30Z

content/courses/connecting-to-offchain-data/verifiable-randomness-functions.md


 The `callback` field is of type
-`[CallbackZC](https://github.com/switchboard-xyz/solana-sdk/blob/9dc3df8a5abe261e23d46d14f9e80a7032bb346c/rust/switchboard-solana/src/oracle_program/accounts/ecvrf.rs#L25)`.
+[CallbackZC](https://github.com/switchboard-xyz/solana-sdk/blob/9dc3df8a5abe261e23d46d14f9e80a7032bb346c/rust/switchboard-solana/src/oracle_program/accounts/ecvrf.rs#L25).


Technically CallbackZC is code so you can use backticks.

mikemaccana · 2024-10-13T07:37:47Z

content/courses/connecting-to-offchain-data/verifiable-randomness-functions.md

@@ -218,24 +224,24 @@ pub struct CallbackZC {
 }
 ```

-This is how you define the Callback struct client side.
+This is how you define the Callback structure on the client side.


Likewise Callback is code.

mikemaccana · 2024-10-13T07:38:06Z

content/courses/connecting-to-offchain-data/verifiable-randomness-functions.md

        { pubkey: clientState, isSigner: false, isWritable: true },
        { pubkey: vrfClientKey, isSigner: false, isWritable: true },
        { pubkey: vrfSecret.publicKey, isSigner: false, isWritable: true },
      ],
-			// use name of instruction
-      ixData: vrfIxCoder.encode("consumeRandomness", ""), // pass any params for instruction here
+			// Use name of instruction


Indents are odd here (they were in the old lesson too)

mikemaccana · 2024-10-13T07:39:11Z

content/courses/connecting-to-offchain-data/verifiable-randomness-functions.md

@@ -401,9 +405,9 @@ pub fn handler(ctx: Context<ConsumeRandomness>) -> Result <()> {
 		// use the get_result method to fetch the randomness results
    let result_buffer = vrf.get_result()?;

-		// check if result buff is all 0's
+		// check if result buff is all zeros


indent needs fixing

mikemaccana · 2024-10-13T07:41:34Z

content/courses/connecting-to-offchain-data/verifiable-randomness-functions.md

+method. This method returns the `current_round.result` field of the `vrf`
+account SwitchboardDecimal format, which is essentially just a buffer of 32
+random
+[u8](https://github.com/switchboard-xyz/solana-sdk/blob/9dc3df8a5abe261e23d46d14f9e80a7032bb346c/rust/switchboard-solana/src/oracle_program/accounts/ecvrf.rs#L65C26-L65C26)


See comments re backticks. Fix SwitchboardDecimal too.

mikemaccana · 2024-10-13T07:41:56Z

content/courses/connecting-to-offchain-data/verifiable-randomness-functions.md

@@ -451,7 +456,7 @@ is provided for you in
 [the main branch of the lab Github repository](https://github.com/Unboxed-Software/michael-burry-escrow).

 The repo contains a "Michael Burry" escrow program. This is a program that
-allows a user to lock up some solana funds in escrow that cannot be withdrawn


Euw gross. Glad you fixed this!

mikemaccana · 2024-10-13T07:42:46Z

content/courses/connecting-to-offchain-data/verifiable-randomness-functions.md

@@ -514,7 +519,7 @@ pub mod instructions;
 pub mod state;
 pub mod errors;

-declare_id!("YOUR_KEY_HERE");
+declare_id!("YOUR_KEY_HERE"); // Replace with your program key


Honestly people can read code, they don't need the comment, maybe just:

Suggested change

declare_id!("YOUR_KEY_HERE"); // Replace with your program key

declare_id!("YOUR_PROGRAM_PUBLIC_KEY_HERE");

To make sure people know it's the public key (which should be obvious but this is training content and we should be explicit).

You could also tell people to run anchor keys sync if necessary.

mikemaccana · 2024-10-13T07:44:43Z

content/courses/connecting-to-offchain-data/verifiable-randomness-functions.md

+with `AccountLoader`. We use this technique because VRF functions are very
+account intensive, and we need to be mindful of the stack. If you'd like to
+learn more about `zero_copy`, take a look at our
+[Program Architecture lesson](/content/courses/program-optimization/program-architecture).


Use .md. I know it's weird but see CONTRIBUTING.md

mikemaccana · 2024-10-13T07:45:34Z

content/courses/connecting-to-offchain-data/verifiable-randomness-functions.md

-send it on it's way.
+Now, we can work on the logic of this instruction. The goal is to gather all of
+the required accounts and pass them to
+[VrfRequestRandomness](https://github.com/switchboard-xyz/solana-sdk/blob/fbef37e4a78cbd8b8b6346fcb96af1e20204b861/rust/switchboard-solana/src/oracle_program/instructions/vrf_request_randomness.rs#L8)


reminder to use backticks.

nandanpathakk and others added 3 commits September 13, 2024 00:11

initial commit

f5eaed7

prettier check

35dd414

Merge branch 'solana-foundation:main' into main

a3033f7

nandanpathakk requested a review from mikemaccana as a code owner September 12, 2024 19:19

mikemaccana suggested changes Oct 13, 2024

View reviewed changes

mikemaccana added the superteam-lesson-updates label Oct 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated Verifiable Randomness Functions #481

Updated Verifiable Randomness Functions #481

nandanpathakk commented Sep 12, 2024

mikemaccana left a comment •

edited

Loading

mikemaccana Oct 13, 2024 •

edited

Loading

mikemaccana left a comment •

edited

Loading

mikemaccana Oct 13, 2024

mikemaccana Oct 13, 2024

mikemaccana Oct 13, 2024

mikemaccana Oct 13, 2024

mikemaccana Oct 13, 2024

mikemaccana Oct 13, 2024

mikemaccana Oct 13, 2024

mikemaccana Oct 13, 2024

mikemaccana Oct 13, 2024

mikemaccana Oct 13, 2024

	declare_id!("YOUR_KEY_HERE"); // Replace with your program key
	declare_id!("YOUR_PROGRAM_PUBLIC_KEY_HERE");

Updated Verifiable Randomness Functions #481

Are you sure you want to change the base?

Updated Verifiable Randomness Functions #481

Conversation

nandanpathakk commented Sep 12, 2024

Summary of Changes

mikemaccana left a comment • edited Loading

Choose a reason for hiding this comment

mikemaccana Oct 13, 2024 • edited Loading

Choose a reason for hiding this comment

mikemaccana left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mikemaccana left a comment •

edited

Loading

mikemaccana Oct 13, 2024 •

edited

Loading

mikemaccana left a comment •

edited

Loading