Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Lookup Tables (LUTs) course #476

Merged
merged 6 commits into from
Oct 2, 2024

Conversation

darkvallen
Copy link
Contributor

@darkvallen darkvallen commented Sep 12, 2024

Summary of Changes

Update the Address Lookup Tables (LUTs) course to comply with the SoLana contributing guide.

  • Simplified explanations of versioned transactions and Address Lookup Tables (LUTs).
  • Updated code examples to align with best practices.
  • Ensured the documentation followed the guidelines from the Solana contributing guide.
  • Enhance readability

Unboxed PR
Unboxed-Software/solana-versioned-transactions#1

…ana contributing guide.

- Simplified explanations of versioned transactions and Address Lookup Tables (LUTs).
- Updated code examples to align with best practices.
- Ensured the documentation followed the guidelines from the Solana contributing guide.
- Enhance readability
@darkvallen darkvallen marked this pull request as draft September 12, 2024 11:56
- Update Course Codes
- Integrated the `@solana/web3.js `library's modern practices and utilized `@solana-developer/solana-helpers` where appropriate, including transaction confirmation and generating Solana Explorer links.

- Enhanced explanation to increase readability
@darkvallen darkvallen marked this pull request as ready for review September 12, 2024 15:28
Copy link
Collaborator

@mikemaccana mikemaccana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good start but a few things to fix, see comments above and we can get this merged - make sure you pay attention to CONTRIBUTING.md

content/courses/program-optimization/lookup-tables.md Outdated Show resolved Hide resolved
content/courses/program-optimization/lookup-tables.md Outdated Show resolved Hide resolved
content/courses/program-optimization/lookup-tables.md Outdated Show resolved Hide resolved
content/courses/program-optimization/lookup-tables.md Outdated Show resolved Hide resolved
content/courses/program-optimization/lookup-tables.md Outdated Show resolved Hide resolved
content/courses/program-optimization/lookup-tables.md Outdated Show resolved Hide resolved
@mikemaccana
Copy link
Collaborator

@darkvallen multiple people have submitted for this but I want to let you know you can easily win this one - you're much closer to having an accepted PR. Just get it in quick!

Fix some review
Updates Based on the Latest Review:

- Revised certain sections for clarity
- Added a callout
- Fixed typos
- Removed the usage of starter code and custom helpers in the lab section, and updated to create files from scratch
- Import only the necessary function from `solana/web3.js`
@darkvallen
Copy link
Contributor Author

@darkvallen multiple people have submitted for this but I want to let you know you can easily win this one - you're much closer to having an accepted PR. Just get it in quick!

Updated @mikemaccana , let me know if there's any further adjustment

- Add filenames
@mikemaccana
Copy link
Collaborator

Thanks @darkvallen ! You won this one.

@mikemaccana mikemaccana merged commit a73581f into solana-foundation:main Oct 2, 2024
4 checks passed
adpthegreat pushed a commit to adpthegreat/developer-content that referenced this pull request Oct 23, 2024
* Update the Address Lookup Tables (LUTs) course to comply with the Solana contributing guide.

- Simplified explanations of versioned transactions and Address Lookup Tables (LUTs).
- Updated code examples to align with best practices.
- Ensured the documentation followed the guidelines from the Solana contributing guide.
- Enhance readability

* Update lookup-tables.md

- Update Course Codes

* Update code snippets

- Integrated the `@solana/web3.js `library's modern practices and utilized `@solana-developer/solana-helpers` where appropriate, including transaction confirmation and generating Solana Explorer links.

- Enhanced explanation to increase readability

* Update lookup-tables.md

Fix some review

* Update lookup-tables.md

Updates Based on the Latest Review:

- Revised certain sections for clarity
- Added a callout
- Fixed typos
- Removed the usage of starter code and custom helpers in the lab section, and updated to create files from scratch
- Import only the necessary function from `solana/web3.js`

* Update lookup-tables.md

- Add filenames
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants