-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile Development: Update the docs + code of Solana Mobile Dapps with Expo #461
Conversation
@nickfrosty Hi, can you check this because the deadline is quite close. Appreciate! |
@XuananLe what dealine? |
@nickfrosty This deadline |
We don't use the @metaplex-foundation/js any more so we need to update the type NFT
Fix README format
…heir classic service since June 2024
Hi @mikemaccana, could you check this out? I see that the priority of this lessons is 99, so I'm doing my best to fix it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! With some small changes we can get this in.
Please add screenshots of the app too, so students can see what they what they will build!
Note the Superteam deadline has been extended.
@mikemaccana I made some changes as you suggested. Can you check out for me ? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more small changes, please address all the comments above then I'll check this out and merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@XuananLe just a reminder to fix the issues in the comments above. The Superteam Earn bounty closes in just over 2 days.
Sure, i'm doing it right now. @mikemaccana can i do a little refactor, the code seems too long right now (100-200 each). |
@mikemaccana I'm done, can you check it out and merge it for me |
@mikemaccana any update so far ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small fixes but nearly done.
@mikemaccana Can you check this out for me, we're nearly done |
…h Expo (solana-foundation#461) * Update solana-mobile-dapps-with-expo.md * Run prettier the README file * Update the type Nft We don't use the @metaplex-foundation/js any more so we need to update the type NFT * Update solana-mobile-dapps-with-expo.md Fix README format * Migrate to Pinata Cloud instead of NFT Storage because they stopped their classic service since June 2024 * Update to Pinata Upload Image and Upload Data * Formatting + Remove unnecessary deps * Fix NftProvider + Update ContentBox * Update Code + Address all the issues * Small Fix + remove rn-fetch-blob because we don't need anymore. * Remove redundant console.log() * Small Fix Env variable * Update Docs + Small fix * Update content/courses/mobile/solana-mobile-dapps-with-expo.md * Update content/courses/mobile/solana-mobile-dapps-with-expo.md --------- Co-authored-by: Mike MacCana <[email protected]>
Problem
react-native-get-random-values
@metaplex-foundation/js
is deprecatedSummary of Changes
@metaplex-foundation/umi-bundle-defaults
,@metaplex-foundation/mpl-candy-machine
,@metaplex-foundation/umi-signer-wallet-adapters
.