Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile Development: Update the docs + code of Solana Mobile Dapps with Expo #461

Merged
merged 18 commits into from
Oct 2, 2024

Conversation

XuananLe
Copy link
Contributor

@XuananLe XuananLe commented Sep 11, 2024

Problem

  • Oudated react-native-get-random-values
  • @metaplex-foundation/js is deprecated
  • Eslint errors + Outdated dependencies with Unboxed-Software's Fake MWA Solana Wallet

Summary of Changes

  • Replace deprecated Metaplex js sdk with @metaplex-foundation/umi-bundle-defaults, @metaplex-foundation/mpl-candy-machine, @metaplex-foundation/umi-signer-wallet-adapters.
  • Update metro.config.js with new polyfill applied to expo-crypto
  • Update and fix all Eslint Errors of Fake MWA Solana Wallet at my new repo

@XuananLe
Copy link
Contributor Author

XuananLe commented Sep 11, 2024

@nickfrosty Hi, can you check this because the deadline is quite close. Appreciate!

@nickfrosty
Copy link
Collaborator

@XuananLe what dealine?

@XuananLe
Copy link
Contributor Author

@nickfrosty This deadline

@nickfrosty nickfrosty requested review from mikemaccana and removed request for nickfrosty September 11, 2024 13:42
We don't use the @metaplex-foundation/js any more so we need to update the type NFT
@XuananLe XuananLe changed the title Update the docs + code of Solana Mobile Dapps with Expo Mobile Development: Update the docs + code of Solana Mobile Dapps with Expo Sep 12, 2024
@XuananLe
Copy link
Contributor Author

Hi @mikemaccana, could you check this out? I see that the priority of this lessons is 99, so I'm doing my best to fix it.

Copy link
Collaborator

@mikemaccana mikemaccana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! With some small changes we can get this in.

Please add screenshots of the app too, so students can see what they what they will build!

Note the Superteam deadline has been extended.

content/courses/mobile/solana-mobile-dapps-with-expo.md Outdated Show resolved Hide resolved
content/courses/mobile/solana-mobile-dapps-with-expo.md Outdated Show resolved Hide resolved
content/courses/mobile/solana-mobile-dapps-with-expo.md Outdated Show resolved Hide resolved
content/courses/mobile/solana-mobile-dapps-with-expo.md Outdated Show resolved Hide resolved
content/courses/mobile/solana-mobile-dapps-with-expo.md Outdated Show resolved Hide resolved
content/courses/mobile/solana-mobile-dapps-with-expo.md Outdated Show resolved Hide resolved
content/courses/mobile/solana-mobile-dapps-with-expo.md Outdated Show resolved Hide resolved
content/courses/mobile/solana-mobile-dapps-with-expo.md Outdated Show resolved Hide resolved
content/courses/mobile/solana-mobile-dapps-with-expo.md Outdated Show resolved Hide resolved
content/courses/mobile/solana-mobile-dapps-with-expo.md Outdated Show resolved Hide resolved
@XuananLe
Copy link
Contributor Author

@mikemaccana I made some changes as you suggested. Can you check out for me ? Thanks

Copy link
Collaborator

@mikemaccana mikemaccana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more small changes, please address all the comments above then I'll check this out and merge.

content/courses/mobile/solana-mobile-dapps-with-expo.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@mikemaccana mikemaccana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XuananLe just a reminder to fix the issues in the comments above. The Superteam Earn bounty closes in just over 2 days.

@XuananLe
Copy link
Contributor Author

XuananLe commented Sep 24, 2024

Sure, i'm doing it right now. @mikemaccana can i do a little refactor, the code seems too long right now (100-200 each).

@XuananLe
Copy link
Contributor Author

@mikemaccana I'm done, can you check it out and merge it for me

@XuananLe
Copy link
Contributor Author

@mikemaccana any update so far ?

Copy link
Collaborator

@mikemaccana mikemaccana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small fixes but nearly done.

content/courses/mobile/solana-mobile-dapps-with-expo.md Outdated Show resolved Hide resolved
content/courses/mobile/solana-mobile-dapps-with-expo.md Outdated Show resolved Hide resolved
content/courses/mobile/solana-mobile-dapps-with-expo.md Outdated Show resolved Hide resolved
content/courses/mobile/solana-mobile-dapps-with-expo.md Outdated Show resolved Hide resolved
content/courses/mobile/solana-mobile-dapps-with-expo.md Outdated Show resolved Hide resolved
content/courses/mobile/solana-mobile-dapps-with-expo.md Outdated Show resolved Hide resolved
content/courses/mobile/solana-mobile-dapps-with-expo.md Outdated Show resolved Hide resolved
@XuananLe
Copy link
Contributor Author

@mikemaccana Can you check this out for me, we're nearly done

@mikemaccana mikemaccana merged commit fc6d1c1 into solana-foundation:main Oct 2, 2024
2 checks passed
adpthegreat pushed a commit to adpthegreat/developer-content that referenced this pull request Oct 23, 2024
…h Expo (solana-foundation#461)

* Update solana-mobile-dapps-with-expo.md

* Run prettier the README file

* Update the type Nft

We don't use the @metaplex-foundation/js any more so we need to update the type NFT

* Update solana-mobile-dapps-with-expo.md

Fix README format

* Migrate to Pinata Cloud instead of NFT Storage because they stopped their classic service since June 2024

* Update to Pinata Upload Image and Upload Data

* Formatting + Remove unnecessary deps

* Fix NftProvider + Update ContentBox

* Update Code + Address all the issues

* Small Fix + remove rn-fetch-blob because we don't need anymore.

* Remove redundant console.log()

* Small Fix Env variable

* Update Docs + Small fix

* Update content/courses/mobile/solana-mobile-dapps-with-expo.md

* Update content/courses/mobile/solana-mobile-dapps-with-expo.md

---------

Co-authored-by: Mike MacCana <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants