Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/immutable owner #14

Merged
merged 9 commits into from
Dec 14, 2023
Merged

Conversation

cogoo
Copy link
Contributor

@cogoo cogoo commented Aug 17, 2023

  • docs(guides): add guide for immutable owner extension
  • style(guides): add metadata for guide

Copy link
Collaborator

@nickfrosty nickfrosty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the specific nits, can you also run prettier formatting on the document?

1. Creating an account with immutable ownership
2. Creating an associated token account with immutable ownership

## Option 1: Creating an account with immutable ownership
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Option 1: Creating an account with immutable ownership
## Creating an account with immutable ownership


Lets explore two options of using the extension:

1. Creating an account with immutable ownership
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Creating an account with immutable ownership
1. [Creating an account with immutable ownership](#creating-an-associated-token account-with-immutable-ownership)

Let's make these internal links to the guide

Lets explore two options of using the extension:

1. Creating an account with immutable ownership
2. Creating an associated token account with immutable ownership
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. Creating an associated token account with immutable ownership
2. [Creating an associated token account with immutable ownership](#creating-an-associated-token account-with-immutable-ownership)

"Program log: The owner authority cannot be changed"
```

## Option 2: Creating an associated token account with immutable ownership
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Option 2: Creating an associated token account with immutable ownership
## Creating an associated token account with immutable ownership

@nickfrosty nickfrosty merged commit d35df9f into solana-foundation:main Dec 14, 2023
2 of 4 checks passed
@nickfrosty
Copy link
Collaborator

This guide on the immutable owner extension is now live!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants