Update the max_slice setting name to max_slice_count

Signed-off-by: Sorabh Hamirwasia <[email protected]>
sohami · Aug 7, 2023 · bf66d5b · bf66d5b
1 parent ce8c6b1
commit bf66d5b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/server/src/main/java/org/opensearch/search/SearchBootstrapSettings.java b/server/src/main/java/org/opensearch/search/SearchBootstrapSettings.java
@@ -19,7 +19,7 @@
 public class SearchBootstrapSettings {
     // settings to configure maximum slice created per search request using OS custom slice computation mechanism. Default lucene
     // mechanism will not be used if this setting is set with value > 0
-    public static final String CONCURRENT_SEGMENT_SEARCH_TARGET_MAX_SLICE_COUNT_KEY = "search.concurrent.max_slice";
+    public static final String CONCURRENT_SEGMENT_SEARCH_TARGET_MAX_SLICE_COUNT_KEY = "search.concurrent.max_slice_count";
     public static final int CONCURRENT_SEGMENT_SEARCH_TARGET_MAX_SLICE_COUNT_DEFAULT_VALUE = 0;
 
     // value == 0 means lucene slice computation will be used

diff --git a/server/src/main/java/org/opensearch/search/internal/ContextIndexSearcher.java b/server/src/main/java/org/opensearch/search/internal/ContextIndexSearcher.java
@@ -450,7 +450,7 @@ public CollectionStatistics collectionStatistics(String field) throws IOExceptio
      * @return leafSlice group to be executed by different threads
      */
     @Override
-    public LeafSlice[] slices(List<LeafReaderContext> leaves) {
+    protected LeafSlice[] slices(List<LeafReaderContext> leaves) {
         // For now using the static setting to get the targetMaxSlice value. It will be updated to dynamic mechanism as part of
         // https://github.com/opensearch-project/OpenSearch/issues/8870 when lucene changes are available
         return slicesInternal(leaves, SearchBootstrapSettings.getTargetMaxSlice());