fix: fix for compliance with new TypeScript rules

package.json

@@ -27,6 +27,7 @@
   "dependencies": {
     "@softwareventures/array": "^0.31.0 || ^0.33.0 || ^2.0.0 || ^3.0.0 || ^4.0.0 || ^5.0.0",
     "@softwareventures/chain": "^0.1.2 || ^1.0.0",
+    "@softwareventures/nullable": "^3.0.0",
     "@types/mime": "^2.0.1 || ^3.0.0",
     "aws-sdk": "^2.553.0 || ^2.884.0",
     "globby": "^11.0.0",

parallel.ts

@@ -1,3 +1,4 @@
+import {notNull} from "@softwareventures/nullable";
 import * as os from "os";
 
 export default async function parallel<T>(tasks: ReadonlyArray<() => Promise<T>>, threads = 0): Promise<T[]> {
@@ -11,7 +12,7 @@ export default async function parallel<T>(tasks: ReadonlyArray<() => Promise<T>>
     async function run(): Promise<void> {
         const i = nextTaskIndex++;
         if (i < tasks.length) {
-            const result = tasks[i]();
+            const result = notNull(tasks[i])();
             results[i] = result;
 
             return result.then(run);
@@ -27,4 +28,4 @@ export default async function parallel<T>(tasks: ReadonlyArray<() => Promise<T>>
 
     return Promise.all(runs)
         .then(() => Promise.all(results));
-}
+}

publish.ts

@@ -1,5 +1,6 @@
 import {concatMapFn, copy, mapFn} from "@softwareventures/array";
 import chain from "@softwareventures/chain";
+import {notNull} from "@softwareventures/nullable";
 import {Credentials, S3} from "aws-sdk";
 import * as fs from "fs";
 import globby = require("globby");
@@ -18,8 +19,8 @@ export default async function publish(config: Config, context: Context): Promise
 
     const {logger} = context;
 
-    const accessKeyId = context.env.AWS_ACCESS_KEY_ID;
-    const secretAccessKey = context.env.AWS_SECRET_ACCESS_KEY;
+    const accessKeyId = notNull(context.env["AWS_ACCESS_KEY_ID"]);
+    const secretAccessKey = notNull(context.env["AWS_SECRET_ACCESS_KEY"]);
 
     const s3 = new S3({
         apiVersion: "2006-03-01",
@@ -61,10 +62,10 @@ export default async function publish(config: Config, context: Context): Promise
                         Bucket: dest.bucket,
                         Key: dest.key,
                         Body: fs.createReadStream(file),
-                        ContentType: dest.contentType || void 0
+                        ...(dest.contentType == null ? null : {ContentType: dest.contentType})
                     }, (err, data) => err ? reject(err) : resolve(data)));
             })))
         .map(async actions => actions.then(parallel))
         .map(async result => result.then((_: ReadonlyArray<S3.PutObjectOutput>) => void 0))
         .value;
-}
+}

tslint.json

@@ -1,3 +1,6 @@
 {
-  "extends": "@softwareventures/tslint-rules"
-}
+  "extends": "@softwareventures/tslint-rules",
+  "rules": {
+    "no-string-literal": false
+  }
+}

verify-conditions.ts

@@ -4,12 +4,12 @@ import {Config} from "./config";
 export let verified = false;
 
 export default async function verifyConditions(config: Config, context: Context): Promise<void> {
-    const accessKeyId = context.env.AWS_ACCESS_KEY_ID;
-    const secretAccessKey = context.env.AWS_SECRET_ACCESS_KEY;
+    const accessKeyId = context.env["AWS_ACCESS_KEY_ID"];
+    const secretAccessKey = context.env["AWS_SECRET_ACCESS_KEY"];
 
     if (!accessKeyId || !secretAccessKey) {
         throw new Error("Environment variables AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY must be set");
     }
 
     verified = true;
-}
+}

yarn.lock

@@ -502,6 +502,13 @@
   dependencies:
     tslib "2.3.0"
 
+"@softwareventures/nullable@^3.0.0":
+  version "3.0.0"
+  resolved "https://registry.yarnpkg.com/@softwareventures/nullable/-/nullable-3.0.0.tgz#979045c99e7c8a9055cb25c3c5cb5b9edfc50085"
+  integrity sha512-kgYOGJHzgZl0QGqMqbRe34i5VaRQUsG+X9AcblJL1lGDq+npLsCS974VSJmOBxnSqIQ5dcgah+zBxHndH8qzfg==
+  dependencies:
+    tslib "2.4.0"
+
 "@softwareventures/ordered@^1.1.0":
   version "1.1.0"
   resolved "https://registry.yarnpkg.com/@softwareventures/ordered/-/ordered-1.1.0.tgz#5bd8929574d309738f6bcccaa017557979a4e303"