Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dev-dependencies #920

Merged
merged 8 commits into from
Nov 27, 2023
Merged

Add dev-dependencies #920

merged 8 commits into from
Nov 27, 2023

Conversation

tomek0123456789
Copy link
Contributor

@tomek0123456789 tomek0123456789 commented Nov 20, 2023 •
edited
Loading

Closes #717

@tomek0123456789 tomek0123456789 marked this pull request as ready for review November 22, 2023 17:09
mkaput
mkaput reviewed Nov 23, 2023
View reviewed changes
Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor stylistic comments. I haven't looked yet at the meat.

scarb/tests/build.rs Outdated Show resolved Hide resolved
scarb/tests/build.rs Outdated Show resolved Hide resolved
scarb/tests/build.rs Outdated Show resolved Hide resolved
scarb/tests/build.rs Outdated Show resolved Hide resolved
scarb/tests/build.rs Outdated Show resolved Hide resolved
mkaput
mkaput reviewed Nov 23, 2023
View reviewed changes
Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good! Let's resolve the topic of packaging dev deps, and then I'll ✅ this.

scarb/src/core/manifest/toml_manifest.rs Outdated Show resolved Hide resolved
@tomek0123456789 tomek0123456789 mentioned this pull request Nov 24, 2023
Closed
mkaput
mkaput requested changes Nov 27, 2023
View reviewed changes
scarb/tests/local_registry.rs Outdated Show resolved Hide resolved
maciektr
maciektr reviewed Nov 27, 2023
View reviewed changes
scarb/tests/build.rs Outdated Show resolved Hide resolved
scarb/tests/build.rs Outdated Show resolved Hide resolved
scarb/tests/build.rs Show resolved Hide resolved
maciektr
maciektr approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@maciektr maciektr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏 👏

@tomek0123456789 tomek0123456789 merged commit 9df0859 into main Nov 27, 2023
11 checks passed
@tomek0123456789 tomek0123456789 deleted the tomek/717-dev-dependencies branch November 27, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciektr maciektr maciektr approved these changes

@mkaput mkaput Awaiting requested review from mkaput

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support dev-dependencies
3 participants
@tomek0123456789 @mkaput @maciektr