Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add include field to the manifest #1842

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Add include field to the manifest #1842

merged 1 commit into from
Dec 13, 2024

Conversation

maciektr
Copy link
Contributor

@maciektr maciektr commented Dec 11, 2024

fixes #1770


Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@maciektr maciektr mentioned this pull request Dec 11, 2024
@maciektr maciektr marked this pull request as ready for review December 11, 2024 19:59
@maciektr maciektr requested a review from a team as a code owner December 11, 2024 19:59
@maciektr maciektr requested a review from mkaput December 12, 2024 13:42
scarb/tests/package.rs Outdated Show resolved Hide resolved
website/docs/registries/publishing.md Outdated Show resolved Hide resolved
scarb/src/core/publishing/manifest_normalization.rs Outdated Show resolved Hide resolved
@maciektr maciektr requested a review from DelevoXDG December 13, 2024 14:19
@maciektr maciektr force-pushed the spr/main/d297a417 branch 2 times, most recently from 01d1add to 8d172a9 Compare December 13, 2024 14:27
Copy link
Contributor

@DelevoXDG DelevoXDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one note re. tests, looks good otherwise

scarb/tests/package.rs Show resolved Hide resolved
@maciektr maciektr enabled auto-merge December 13, 2024 14:44
@maciektr maciektr disabled auto-merge December 13, 2024 14:48
@maciektr maciektr enabled auto-merge December 13, 2024 14:51
fixes #1770
commit-id:d297a417
@maciektr maciektr added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit 939c7f1 Dec 13, 2024
22 of 29 checks passed
@maciektr maciektr deleted the spr/main/d297a417 branch December 13, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure procmacros can be manually aot-compiled
3 participants