Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add target selector #1347

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Add target selector #1347

merged 1 commit into from
Jun 12, 2024

Conversation

maciektr
Copy link
Contributor

@maciektr maciektr commented Jun 11, 2024 •
edited
Loading

commit-id:2ec662b7

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This was referenced Jun 11, 2024
Merged
Merged
@maciektr maciektr marked this pull request as ready for review June 11, 2024 09:19
@maciektr maciektr force-pushed the spr/main/2ec662b7 branch from f0c052f to 7542bfd Compare June 11, 2024 09:22
@maciektr maciektr force-pushed the spr/main/8273b556 branch from 3e8b479 to 46b8ade Compare June 11, 2024 09:22
THenry14
THenry14 approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@THenry14 THenry14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, left just one question but since it may come from my lack of understanding of the project (yet!) this is rather a nitpick

scarb/src/bin/scarb/args.rs Show resolved Hide resolved
@maciektr maciektr force-pushed the spr/main/8273b556 branch from 46b8ade to 0309783 Compare June 11, 2024 14:46
@maciektr maciektr force-pushed the spr/main/2ec662b7 branch from 7542bfd to dd65f95 Compare June 11, 2024 14:46
github-merge-queue bot pushed a commit that referenced this pull request Jun 11, 2024
@maciektr
Scarb expand initial impl (#1344)
1e920b0 
commit-id:8273b556

---

**Stack**:
- #1348
- #1347
- #1344 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
Base automatically changed from spr/main/8273b556 to main June 11, 2024 16:00
@maciektr
Add target selector
8cb1aea 
commit-id:2ec662b7
@maciektr maciektr force-pushed the spr/main/2ec662b7 branch from dd65f95 to 8cb1aea Compare June 12, 2024 14:07
@maciektr maciektr enabled auto-merge June 12, 2024 14:07
@maciektr maciektr added this pull request to the merge queue Jun 12, 2024
Merged via the queue into main with commit 79b2ce1 Jun 12, 2024
23 checks passed
@maciektr maciektr deleted the spr/main/2ec662b7 branch June 12, 2024 14:56
@BrewTestBot BrewTestBot mentioned this pull request Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@THenry14 THenry14 THenry14 approved these changes

@mkaput mkaput mkaput approved these changes

@DelevoXDG DelevoXDG Awaiting requested review from DelevoXDG

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maciektr @mkaput @THenry14