Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for compiler experimental features #1011

Closed
wants to merge 1 commit into from
Closed

Add support for compiler experimental features #1011

wants to merge 1 commit into from

Conversation

tomek0123456789
Copy link
Contributor

@tomek0123456789 tomek0123456789 commented Dec 22, 2023 •
edited
Loading

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@tomek0123456789 tomek0123456789 mentioned this pull request Dec 22, 2023
Merged
@tomek0123456789 tomek0123456789 marked this pull request as ready for review December 22, 2023 11:07
maciektr
maciektr reviewed Dec 27, 2023
View reviewed changes
scarb/src/core/manifest/mod.rs Outdated Show resolved Hide resolved
scarb-metadata/src/lib.rs Outdated Show resolved Hide resolved
scarb/src/core/manifest/toml_manifest.rs Outdated Show resolved Hide resolved
mkaput
mkaput requested changes Jan 2, 2024
View reviewed changes
Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we discussed this change with Cairo team? Do they want us to make this available to end users?

@maciektr
Copy link
Contributor

maciektr commented Jan 2, 2024

Have we discussed this change with Cairo team? Do they want us to make this available to end users?

@mkaput this has been directly requested by the compiler team

mkaput
mkaput requested changes Jan 3, 2024
View reviewed changes
scarb/src/core/manifest/mod.rs Outdated Show resolved Hide resolved
scarb/src/core/manifest/toml_manifest.rs Outdated Show resolved Hide resolved
website/docs/reference/workspaces.md Outdated Show resolved Hide resolved
mkaput
mkaput requested changes Jan 8, 2024
View reviewed changes
scarb-metadata/src/lib.rs Outdated Show resolved Hide resolved
scarb/src/ops/metadata.rs Outdated Show resolved Hide resolved
mkaput
mkaput requested changes Jan 8, 2024
View reviewed changes
scarb/src/core/manifest/toml_manifest.rs Outdated Show resolved Hide resolved
scarb/src/core/manifest/toml_manifest.rs Outdated Show resolved Hide resolved
utils/scarb-test-support/src/project_builder.rs Outdated Show resolved Hide resolved
website/docs/reference/manifest.md Show resolved Hide resolved
scarb/src/core/manifest/mod.rs Outdated Show resolved Hide resolved
scarb/src/compiler/db.rs Show resolved Hide resolved
This was referenced Jan 8, 2024
Open
Open
mkaput
mkaput reviewed Jan 12, 2024
View reviewed changes
Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far!

@tomek0123456789
Add support for compiler experimental features
de86427 
commit-id:480c1b28

review update

review update

fix docs, add todo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaput mkaput mkaput approved these changes

@szymmis szymmis Awaiting requested review from szymmis

@maciektr maciektr Awaiting requested review from maciektr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomek0123456789 @maciektr @mkaput