Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: New style props support in CSS animations #6944

Merged
merged 6 commits into from
Jan 29, 2025
Merged

feat: New style props support in CSS animations #6944

merged 6 commits into from
Jan 29, 2025

Conversation

MatiPl01
Copy link
Member

@MatiPl01 MatiPl01 commented Jan 27, 2025 •
edited
Loading

Summary

This PR adds support for new animation properties added in RN 0.77 and implements respective examples for all of added props.

Support was added for the following props

  • boxSizing
  • outlineColor
  • outlineOffset
  • outlineStyle
  • outlineWidth
  • mixBlendMode

Supported props have been also updated in this spreadsheet.

@MatiPl01 MatiPl01 self-assigned this Jan 27, 2025
@MatiPl01 MatiPl01 force-pushed the @matipl01/new-style-props-css-support branch from a947f73 to 67f294a Compare January 28, 2025 11:52
@MatiPl01 MatiPl01 changed the base branch from main to @matipl01/web-and-navigation-improvements January 28, 2025 11:53
@MatiPl01 MatiPl01 marked this pull request as ready for review January 28, 2025 13:29
@MatiPl01 MatiPl01 requested a review from piaskowyk January 28, 2025 13:29
piaskowyk
piaskowyk approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@piaskowyk piaskowyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 I have just one question

packages/react-native-reanimated/src/propsAllowlists.ts Show resolved Hide resolved
Base automatically changed from @matipl01/web-and-navigation-improvements to main January 29, 2025 11:05
@MatiPl01 MatiPl01 force-pushed the @matipl01/new-style-props-css-support branch from b8ce974 to b61d74a Compare January 29, 2025 11:08
@MatiPl01 MatiPl01 added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit 0e0cf96 Jan 29, 2025
20 checks passed
@MatiPl01 MatiPl01 deleted the @matipl01/new-style-props-css-support branch January 29, 2025 11:09
@MatiPl01 MatiPl01 mentioned this pull request Jan 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piaskowyk piaskowyk piaskowyk approved these changes

Assignees

@MatiPl01 MatiPl01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatiPl01 @piaskowyk