feat(Worklets): JS code duplication #6921
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
changed the title
…lets-source-sets' into @tjzel/worklets/duplicate-reanimated-code
…worklets/duplicate-javascript
Base automatically changed from
@tjzel/worklets/duplicate-reanimated-code
to
main
January 29, 2025 13:42
tjzel
commented
Jan 29, 2025
Comment on lines
-72
to
-76
| - name: Use external worklets | ||
| if: ${{ inputs.use-external-worklets == 'true' }} | ||
| working-directory: ${{ env.COMMON_APP_DIR }} | ||
| run: yarn add react-native-worklets@workspace:"*" | ||
|
|
There was a problem hiding this comment.
I don't understand how things keep duplicating when I rebase 😭
tjzel
changed the title
bartlomiejbloniarz
approved these changes
Jan 30, 2025
Comment on lines
-72
to
-76
| - name: Use external worklets | ||
| if: ${{ inputs.use-external-worklets == 'true' }} | ||
| working-directory: ${{ env.COMMON_APP_DIR }} | ||
| run: yarn add react-native-worklets@workspace:"*" | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR I'm moving the
WorkletsModulepart of the JS code toreact-native-worklets. Reanimated would still have those files duplicated via a mechanism introduced in #6827.Now in Reanimated all worklets code must be acquired via a special
WorkletsResolvermodule. This is a temporary solution and will be dropped once we requirereact-native-workletsas a mandatory dependency forreact-native-reanimated.react-native-workletswouldn't be used in the app even though it's not a dependency.WorkletsResolver.PlatformChecker.tsexplicitly inreact-native-worklets. This file is small and stable so I don't consider this to be an issue. We can think of some better solution once the package is more polished.commonTypes.tsbetween packages.Test plan
Fabric example should work with & without
react-native-workletsinstalled. You can check using the debugger that always the correct instance of Worklets' JavaScript code is used.