New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix FlipCard example on Android/iOS #6823

Merged

patrycjakalinska merged 1 commit into main from @patrycjakalinska/flipcard-example-fix

Dec 20, 2024

Contributor

patrycjakalinska commented Dec 16, 2024 •

edited

Loading

Summary

FlipCard example was "flickering" and not showing current card (on iOS and Android). Change in styles fixed that.

It was discovered in #6722

Before:

Screen.Recording.2024-12-16.at.15.42.06.mov

After:

Screen.Recording.2024-12-16.at.15.42.41.mov


          fix backfaceVisibility on flipCard

Kinouetpoupinette commented Dec 16, 2024 via email

De quoi s agit t il ? Le lun. 16 déc. 2024, 15:46, Patrycja Kalińska ***@***.***> a écrit :

Summary FlipCard example was "flickering" and not showing current card (on iOS and Android). Change in styles fixed that. Before: https://github.com/user-attachments/assets/373980e1-c86d-4521-bfe3-fe1e312ba920 After: https://github.com/user-attachments/assets/32b47476-27c2-4eb8-9300-362c45ffb238 ------------------------------ You can view, comment on, or merge this pull request online at: #6823 Commit Summary - 6870006 <6870006> fix backfaceVisibility on flipCard File Changes (2 files <https://github.com/software-mansion/react-native-reanimated/pull/6823/files> ) - *M* packages/docs-reanimated/blog/flip-card.md <https://github.com/software-mansion/react-native-reanimated/pull/6823/files#diff-252b6fa8d53c98213d805c203235bbb3cdd23f36df174b919c807ce7b1363d97> (6) - *M* packages/docs-reanimated/static/examples/FlipCard.js <https://github.com/software-mansion/react-native-reanimated/pull/6823/files#diff-6c7cc6a550c412d05c106e1dffd2e0cb84abe6b7eeec6dbec2815fc13986c08f> (2) Patch Links: - https://github.com/software-mansion/react-native-reanimated/pull/6823.patch - https://github.com/software-mansion/react-native-reanimated/pull/6823.diff — Reply to this email directly, view it on GitHub <#6823>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVM4GI4H3MUGPY74PVWYGUL2F3RU5AVCNFSM6AAAAABTWJ2VI2VHI2DSMVQWIX3LMV43ASLTON2WKOZSG42DENJYGU3TGNQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

patrycjakalinska marked this pull request as ready for review

December 19, 2024 16:48

patrycjakalinska requested review from kacperkapusciak and piaskowyk

December 19, 2024 16:48

kacperkapusciak approved these changes

View reviewed changes

Member

kacperkapusciak left a comment

lgtm!

patrycjakalinska added this pull request to the merge queue

Merged via the queue into main with commit b2c5914

10 checks passed

patrycjakalinska deleted the @patrycjakalinska/flipcard-example-fix branch

December 20, 2024 09:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet