-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable V8 nightly CI #6533
Merged
Merged
Enable V8 nightly CI #6533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for re-enabling this! Can we also migrate npx react-native init
to npx @react-native-community/cli init
in all CI workflows in a separate PR?
Sure thing 🫡 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary <!-- Explain the motivation for this PR. Include "Fixes #<number>" if applicable. --> Migrating deprecated `npx react-native init` command to `npx @react-native-community/cli init` as mentioned [here](#6533 (review)) --------- Co-authored-by: Tomasz Żelawski <[email protected]>
tjzel
added a commit
that referenced
this pull request
Dec 13, 2024
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary <!-- Explain the motivation for this PR. Include "Fixes #<number>" if applicable. --> Migrating deprecated `npx react-native init` command to `npx @react-native-community/cli init` as mentioned [here](#6533 (review)) --------- Co-authored-by: Tomasz Żelawski <[email protected]>
tjzel
added a commit
that referenced
this pull request
Dec 13, 2024
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary <!-- Explain the motivation for this PR. Include "Fixes #<number>" if applicable. --> Migrating deprecated `npx react-native init` command to `npx @react-native-community/cli init` as mentioned [here](#6533 (review)) --------- Co-authored-by: Tomasz Żelawski <[email protected]>
tjzel
added a commit
that referenced
this pull request
Dec 13, 2024
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary <!-- Explain the motivation for this PR. Include "Fixes #<number>" if applicable. --> Migrating deprecated `npx react-native init` command to `npx @react-native-community/cli init` as mentioned [here](#6533 (review)) --------- Co-authored-by: Tomasz Żelawski <[email protected]>
tomekzaw
pushed a commit
that referenced
this pull request
Jan 9, 2025
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> <!-- Explain the motivation for this PR. Include "Fixes #<number>" if applicable. --> Migrating deprecated `npx react-native init` command to `npx @react-native-community/cli init` as mentioned [here](#6533 (review)) --------- Co-authored-by: Tomasz Żelawski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now V8 supports react native 0.75 so we can turn on our CI 🎉
Test plan
Check CI ✅