Migrate ShareableJSRef to jsi::NativeState
#6389
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 8, 2024
tomekzaw
force-pushed
the
@tomekzaw/shareablejsref-native-state
branch
from
92028e1 to
af8241f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
According to this tweet posted by @tmikov from Hermes team, usage of
jsi::HostObjectis strongly discouraged.This PR migrates
ShareableJSRefthat used to be ajsi::HostObjecttojsi::NativeStateas well as renames it toShareableNativeStatefor consistency. Finally, this PR also updates all usages accordingly.Caution
jsi::NativeStatewas added in React Native 0.71 but requires 0.72 to work correctly on Android or iOS. Also, it still does not work on some configurations, e.g. macOS with JSC (Hermes disabled) – available from [email protected]. Let's hold this PR untiljsi::NativeStateis supported on all supported configurations.Note
TODO: compare performance
Test plan