Fix border styling issues in RNGestureHandlerButton
#3409
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds missing prop styles fields to the RNGestureHandlerButton delegate.
Since a lot of new logic would be required to support these new props, I decided to also rewrite
ButtonViewGroup
to useReactViewGroup
instead ofViewGroup
, as our current implementation seemed to already share most of it's drawing-related code with theReactViewGroup
.The only logic missing from
ReactViewGroup
was theripple
logic, the foreground logic, and the touch handling logic, so i kept those in place. Remaining redundant code was removed.Fixes #3304
Test plan
Collapsed example