Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump example to Expo 52 #3317

Merged
merged 11 commits into from
Jan 28, 2025
Merged

Bump example to Expo 52 #3317

merged 11 commits into from
Jan 28, 2025

Conversation

latekvo
Copy link
Contributor

@latekvo latekvo commented Jan 9, 2025 •
edited
Loading

Description

This PR fixes some issues that occur when trying to use RNGH with expo sdk 52.

This bump will help with testing the new expo features and new react native features which will be useful for optimising Gesture Handler.

Test plan

@latekvo latekvo closed this Jan 9, 2025
@latekvo latekvo changed the title Bump sdk to version 52 Bump to Expo 52 Jan 10, 2025
@latekvo latekvo reopened this Jan 10, 2025
@latekvo latekvo changed the title Bump to Expo 52 Bump example to Expo 52 Jan 10, 2025
@latekvo latekvo marked this pull request as ready for review January 24, 2025 17:10
@latekvo
Copy link
Contributor Author

latekvo commented Jan 24, 2025

Tested on both fabric and paper, on android and iOS.
Example app builds and runs with no issues.

Regarding 851a72c, SharedValue's signature was changed in either 3.15.x or 3.16.x versions of react-native-reanimated, which causes type linter errors as long as the versions between Example package.json and root package.json are misaligned.

@latekvo latekvo requested review from m-bert and j-piasecki January 24, 2025 17:43
m-bert
m-bert reviewed Jan 27, 2025
View reviewed changes
Copy link
Contributor

@m-bert m-bert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my case I can't run android on fabric. There are some errors related to react-native-async-storage and codegen. Have you seen that before?

@latekvo latekvo merged commit 15cdd8d into main Jan 28, 2025
6 of 8 checks passed
@latekvo latekvo deleted the @latekvo/fix-issues-in-expo-52 branch January 28, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-bert m-bert m-bert approved these changes

@j-piasecki j-piasecki j-piasecki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@latekvo @j-piasecki @m-bert