Fix definition lookups for let a =-style bindings
#119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkaput
requested review from
Arcticae and
Draggu
and removed request for
a team
This was referenced Dec 19, 2024
Arcticae
approved these changes
Dec 20, 2024
|
|
||
| //! > cairo_code | ||
| fn main() { | ||
| let ab<caret>c: felt252 = 0; |
There was a problem hiding this comment.
What about an example without the type declaration?
let a = 1;
These tests are very incomplete, but they serve as a good basis for future work. commit-id:2d88cb6c
commit-id:02fe336d
mkaput
force-pushed
the
spr/main/2d88cb6c
branch
from
f470be1 to
4440471
Compare
mkaput
force-pushed
the
spr/main/02fe336d
branch
from
45edd55 to
3f96bd4
Compare
piotmag769
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
textDocument/referencesimplementation #123textDocuments/referencesimplementation #122let a =-style bindings #119 ⬅