Fix jitter causing panics on wasm32-unknown-unknown #2
Conversation
| @@ -20,6 +20,9 @@ categories = [ | |||
| maintenance = { status = "actively-developed" } | |||
|
|
|||
| # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html | |||
| [features] | |||
| wasm-bindgen = ["rand/wasm-bindgen"] | |||
There was a problem hiding this comment.
@Zireael-N does this relate to your other pull?
There was a problem hiding this comment.
I'd like to better understand how to catch these errors. I'm new to the wasm world so I may do something run but wouldn't this catch it?
again/.github/workflows/main.yml
Line 46 in 928e06c
There was a problem hiding this comment.
It's a runtime error.
There was a problem hiding this comment.
I think, the easiest thing you can do is to make CI build a wasm binary and then attempt to interface with it via NodeJS to see if it throws an exception.
There was a problem hiding this comment.
Actually, this won't work with NodeJS because wasm-timer assumes that it's being run in a browser and expects window to be available. :(
wasm-bindgen, according to its guide, can run tests using headless browsers but I've never done that.
There was a problem hiding this comment.
this thread might be helpful. it seems possible to get rand working with wasm bindgen. I'll do some research rust-random/rand#616
There was a problem hiding this comment.
It does work if you use the wasm-bindgen feature. The features I added in this PR just tell cargo to enable corresponding features while compiling rand.
There was a problem hiding this comment.
Aha rust-random/rand#810 (comment) I was missing a bit of context here. Can you merge master to fix the merge conflict. I'll merge this aftet
There was a problem hiding this comment.
Rebased and force-pushed.
There was a problem hiding this comment.
I'll follow up on figuring out what an integration test looks like this in ci in #4
|
thanks for your patches @Zireael-N I just published a new version with your other change and a new version with this change should be on its way to crates.io shortly https://github.com/softprops/again/actions/runs/120210531 |
getrandom, whichranddepends on, needs to know how to interface with JS in order to work. Otherwise, it causes an "unreachable" error:https://github.com/rust-random/getrandom/tree/0ad1c7721455b644a775bb4647806ab631250c14#features