Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] 선착순 이벤트 당첨자수 스케줄링 #17

Merged
merged 5 commits into from
Aug 7, 2024

Conversation

eckrin
Copy link
Collaborator

@eckrin eckrin commented Aug 7, 2024

🎯 이슈 번호

Issue #16

💡 작업 내용

  • 이벤트 스케줄러 구현

💡 자세한 설명

✅ 셀프 체크리스트

  • PR 제목을 형식에 맞게 작성했나요?
  • 브랜치 전략에 맞는 브랜치에 PR을 올리고 있나요? (master/main이 아닙니다.)
  • Reviewers, Labels, Projects를 등록했나요?
  • 작업 도중 문서 수정이 필요한 경우 잘 수정했나요?
  • 테스트는 잘 통과했나요?
  • 불필요한 코드는 제거했나요?

*
*/
@Scheduled(cron = "0 45 19 * * *")
public void setDailyQuiz() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이부분 메소드 이름을 바꾸는건 어떨까요

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앗 실수했습니다

}


@Scheduled(cron = "0 20 3 * * *")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이부분 실수로 삭제 안하신것같아요

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luna156
Copy link
Collaborator

luna156 commented Aug 7, 2024

그 이외에는 문제없는것 같습니다. 수고하셨습니다.

@eckrin
Copy link
Collaborator Author

eckrin commented Aug 7, 2024

넵 리뷰 감사합니다

@eckrin eckrin merged commit a5575ee into master Aug 7, 2024
1 check passed
@eckrin eckrin deleted the feat/event-scheduling branch August 7, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants