Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] 모델에 타입, 가격 정보 추가 #386

Merged
merged 7 commits into from
Aug 24, 2023
Merged

[Feature] 모델에 타입, 가격 정보 추가 #386

merged 7 commits into from
Aug 24, 2023

Conversation

jjddhh
Copy link
Collaborator

@jjddhh jjddhh commented Aug 24, 2023

개요

작업사항

  • type, price 정보 추가

@jjddhh jjddhh self-assigned this Aug 24, 2023
@github-actions
Copy link

github-actions bot commented Aug 24, 2023 •
edited
Loading

Test Results

101 tests  ±0   101 ✔️ ±0   4s ⏱️ -1s
  49 suites ±0       0 💤 ±0 
  49 files   ±0       0 ❌ ±0 

Results for commit 0712dad. ± Comparison against base commit b2babb7.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

📝 테스트 커버리지 리포트입니다

File Coverage [74.61%] 🍏
Type.java 100% 🍏
Model.java 87.63% 🍏
ModelDto.java 75.19% 🍏
GetModelsJpaAdaptor.java 0% ❌
ModelEntity.java 0% ❌
Total Project Coverage 60.67% 🍏

SeoSiun
SeoSiun approved these changes Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@SeoSiun SeoSiun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link

📝 테스트 커버리지 리포트입니다

File Coverage [73.89%] 🍏
Type.java 100% 🍏
Model.java 87.5% 🍏
ModelDto.java 77.33% 🍏
BaseTime.java 0% ❌
GetModelsJpaAdaptor.java 0% ❌
ModelEntity.java 0% ❌
Total Project Coverage 60.73% 🍏

@jjddhh jjddhh merged commit 9e1dfea into be-dev Aug 24, 2023
3 checks passed
@jjddhh jjddhh deleted the be-feat/model-type branch August 24, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeoSiun SeoSiun SeoSiun approved these changes

@startartart startartart Awaiting requested review from startartart startartart is a code owner

@wonho1401 wonho1401 Awaiting requested review from wonho1401 wonho1401 is a code owner

@sseungmn sseungmn Awaiting requested review from sseungmn sseungmn is a code owner

Assignees

@jjddhh jjddhh

Labels
✨ be 🚀 feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjddhh @SeoSiun