Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] estimate 패키지 구조 변경 및 usecase 단위 port, adapter 추가 #325

Merged
merged 7 commits into from
Aug 20, 2023

Conversation

jjddhh
Copy link
Collaborator

@jjddhh jjddhh commented Aug 20, 2023

개요

작업사항

  • usecase별 port, adaptor 추가
  • 패키지 구조 변경
  • 불필요하게 긴 변수명 수정

고민사항

  • request에 변수가 너무 많다보니 usecase로 어떤 방식으로 넘겨주는것이 좋을지 고민. 일단은 데이터 접근 계층에 넘길때는 전부 꺼내서 넘겨줌

@github-actions
Copy link

github-actions bot commented Aug 20, 2023

Test Results

80 tests  ±0   80 ✔️ ±0   3s ⏱️ -1s
35 suites ±0     0 💤 ±0 
35 files   ±0     0 ±0 

Results for commit 163bfdf. ± Comparison against base commit 4f44996.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

📝 테스트 커버리지 리포트입니다

File Coverage [33.84%]
GetEstimateUseCase.java 89.47% 🍏
Estimate.java 83.13% 🍏
EstimateTrimDto.java 77.78% 🍏
EstimateBodyTypeDto.java 77.78% 🍏
EstimateWheelDriveDto.java 77.78% 🍏
EstimateEngineDto.java 77.78% 🍏
GetEstimateResponse.java 75% 🍏
EstimateOptionDto.java 72.94% 🍏
EstimateInteriorColorDto.java 72.94% 🍏
EstimateExteriorColorDto.java 70.09% 🍏
EstimateController.java 68% 🍏
EstimateEntity.java 0%
GetEstimateAdaptor.java 0%
CreateEstimateAdaptor.java 0%
CreateEstimateUseCase.java 0%
Total Project Coverage 53.36% 🍏

Copy link
Collaborator

@SeoSiun SeoSiun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm👍

@jjddhh jjddhh merged commit 95bc5b1 into be-dev Aug 20, 2023
3 checks passed
@jjddhh jjddhh deleted the be-refactor/estimate branch August 20, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants