Fixed isEmpty confusing objects (with special properties e.g. length and size) with keyed or indexed collections plus new functions under typed
#382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(typed): added `isIndexedCollections` for all sorts of arrays feat(typed): added `isSet` and `isMap` for `Set` and `Map` respectively feat(typed): added `isKeyedCollections` for both `Set` and `Map` feat(typed): added `isBigInt` for `BigInt` feat(typed): extended `isInt` to support `BigInt` feat(typed): updated `isEmpty` to account for the newly supported types fix(typed): fixed `isEmpty` confusing objects (with special properties e.g. `length` and `size`) with keyed or indexed collections test(typed): added and updated tests for the new methods
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Wow, this is an epic PR, @UnKnoWn-Consortium. We'd appreciate it over at radashi-org/radashi. Note that we've reorganized a bit, so it won't be a simple switch of the upstream branch. Also, if you decide to pursue this PR further, we'd need additions to the docs and we should bring the bug fixes into a separate PR, separate from the new features. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat(typed): added
isTypedArrayto account for typed arraysfeat(typed): added
isIndexedCollectionsfor all sorts of arraysfeat(typed): added
isSetandisMapforSetandMaprespectivelyfeat(typed): added
isKeyedCollectionsfor bothSetandMapfeat(typed): added
isBigIntforBigIntfeat(typed): extended
isIntto supportBigIntfeat(typed): updated
isEmptyto account for the newly supported typesfix(typed): fixed
isEmptyconfusing objects (with special properties e.g.lengthandsize) with keyed or indexed collectionstest(typed): added and updated tests for the new methods
Checklist
package.jsonhas been bumped (matching semver)yarn buildcommand has been run and to update thecdndirectory/docsdirectory) has been updatedResolves
Resolves #366