-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit test cases for block volume and block volume snapshot #1299
Open
nguptaopensds
wants to merge
4
commits into
sodafoundation:master
Choose a base branch
from
nguptaopensds:test_vol
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguptaopensds
force-pushed
the
test_vol
branch
2 times, most recently
from
June 17, 2020 13:38
800a12b
to
7f68c79
Compare
nguptaopensds
changed the title
Unit test cases for block volume
Unit test cases for block volume and block volume snapshot
Jun 17, 2020
kumarashit
reviewed
Jun 20, 2020
Codecov Report
@@ Coverage Diff @@
## master #1299 +/- ##
==========================================
- Coverage 41.48% 39.67% -1.81%
==========================================
Files 53 53
Lines 7752 6966 -786
==========================================
- Hits 3216 2764 -452
+ Misses 4021 3662 -359
- Partials 515 540 +25
|
kumarashit
approved these changes
Sep 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
Adding unit test cases for block volumes
Which issue(s) this PR fixes:
#1270
Fixes #
Test Report Added?:
/kind TESTED
Test Report:
Special notes for your reviewer: