-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attachment unit test cases in SODA API pkg/controller #1287
base: master
Are you sure you want to change the base?
Conversation
52b2d2d
to
1574990
Compare
@NajmudheenCT please check once |
4525ce3
to
7195ca7
Compare
Codecov Report
@@ Coverage Diff @@
## master #1287 +/- ##
==========================================
- Coverage 41.48% 39.36% -2.13%
==========================================
Files 53 53
Lines 7752 6966 -786
==========================================
- Hits 3216 2742 -474
+ Misses 4021 3692 -329
- Partials 515 532 +17
|
}`) | ||
var expected model.VolumeAttachmentSpec | ||
json.Unmarshal(expectedJson, &expected) | ||
fmt.Println(expected) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is for debugging, please remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
This PR is adding the unit test cases for attachment.go in pkg/controller
Which issue(s) this PR fixes:
Fixes #
Test Report Added?:
Test Report:
Special notes for your reviewer: